Message-ID: <571512B0.90303@nvidia.com>
Date: Mon, 18 Apr 2016 22:30:32 +0530
From: Laxman Dewangan <ldewangan@nvidia.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
MIME-Version: 1.0
To: Stephen Warren <swarren@wwwdotorg.org>, <linus.walleij@linaro.org>
CC: <gnurou@gmail.com>, <thierry.reding@gmail.com>,
        <linux-gpio@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] gpio: tegra: Remove the need of keeping device handle
 for gpio driver
References: <1460969178-20914-1-git-send-email-ldewangan@nvidia.com> <1460969178-20914-2-git-send-email-ldewangan@nvidia.com> <57150B81.6040104@wwwdotorg.org>
In-Reply-To: <57150B81.6040104@wwwdotorg.org>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 754
Lines: 17


On Monday 18 April 2016 09:59 PM, Stephen Warren wrote:
> On 04/18/2016 02:46 AM, Laxman Dewangan wrote:
>> Remove the file static device handle variable as this is just
>> required for prints. The required handle can be stored in
>> tegra_gpio_chip and hence it become redundancy.
>
> This seems fine as far as it goes, but if it's worth doing this, 
> please move all the globals into the GPIO chip rather than just one of 
> the 7 globals.

the device pointer is part of the gpiochip and so it is better to use 
gpiochip parent member instead of locally duplicating.

However, moving to other global variables needs some major changes and I 
think it should be treated as independent of this patch.
This patch just utilizes the gpiochip.parent here.