Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751868AbcDRTYi (ORCPT <rfc822;w@1wt.eu>);
	Mon, 18 Apr 2016 15:24:38 -0400
Received: from mail-oi0-f43.google.com ([209.85.218.43]:33126 "EHLO
	mail-oi0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751509AbcDRTYg (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 18 Apr 2016 15:24:36 -0400
MIME-Version: 1.0
In-Reply-To: <1461004173.3765.73.camel@infradead.org>
References: <1460979793-6621-1-git-send-email-mst@redhat.com>
 <1460980717.12793.43.camel@infradead.org> <20160418160731-mutt-send-email-mst@redhat.com>
 <1460988232.22654.7.camel@infradead.org> <20160418170534-mutt-send-email-mst@redhat.com>
 <1460992923.3765.8.camel@infradead.org> <20160418182320-mutt-send-email-mst@redhat.com>
 <1460994701.3765.23.camel@infradead.org> <20160418190203-mutt-send-email-mst@redhat.com>
 <1461004173.3765.73.camel@infradead.org>
From: Andy Lutomirski <luto@amacapital.net>
Date: Mon, 18 Apr 2016 12:24:15 -0700
Message-ID: <CALCETrXGC9X6fndftzUKKQ76TXSARHotW8Kz3KcO6opQ-oLaqA@mail.gmail.com>
Subject: Re: [PATCH RFC] fixup! virtio: convert to use DMA api
To: David Woodhouse <dwmw2@infradead.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
        "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>, peterx@redhat.com,
        Cornelia Huck <cornelia.huck@de.ibm.com>,
        Stefan Hajnoczi <stefanha@redhat.com>, Kevin Wolf <kwolf@redhat.com>,
        Amit Shah <amit.shah@redhat.com>, qemu-block@nongnu.org,
        Jason Wang <jasowang@redhat.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Andy Lutomirski <luto@kernel.org>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        Wei Liu <wei.liu2@citrix.com>,
        Linux Virtualization <virtualization@lists.linux-foundation.org>,
        kvm list <kvm@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 643
Lines: 12

On Mon, Apr 18, 2016 at 11:29 AM, David Woodhouse <dwmw2@infradead.org> wrote:
> For x86, you *can* enable virtio-behind-IOMMU if your DMAR tables tell
> the truth, and even legacy kernels ought to cope with that.
> FSVO 'ought to' where I suspect some of them will actually crash with a
> NULL pointer dereference if there's no "catch-all" DMAR unit in the
> tables, which puts it back into the same camp as ARM and Power.

I think x86 may get a bit of a free pass here.  AFAIK the QEMU IOMMU
implementation on x86 has always been "experimental", so it just might
be okay to change it in a way that causes some older kernels to OOPS.

--Andy