Message-ID: <57153833.7060809@hpe.com>
Date: Mon, 18 Apr 2016 15:40:35 -0400
From: Waiman Long <waiman.long@hpe.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130109 Thunderbird/10.0.12
MIME-Version: 1.0
To: Davidlohr Bueso <dave@stgolabs.net>
CC: <mingo@kernel.org>, <peterz@infradead.org>, <linux-kernel@vger.kernel.org>,
        Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH -tip 3/3] locking/pvqspinlock: Robustify init_qspinlock_stat()
References: <1460961103-24953-1-git-send-email-dave@stgolabs.net> <1460961103-24953-3-git-send-email-dave@stgolabs.net>
In-Reply-To: <1460961103-24953-3-git-send-email-dave@stgolabs.net>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2016 19:40:41.0371 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TU4PR84MB0318
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1441
Lines: 43

On 04/18/2016 02:31 AM, Davidlohr Bueso wrote:
> Specifically around the debugfs file creation calls,
> I have no idea if they could ever possibly fail, but
> this is core code (debug aside) so lets at least
> check the return value and inform anything fishy.
>
> Signed-off-by: Davidlohr Bueso<dbueso@suse.de>
> ---
>   kernel/locking/qspinlock_stat.h | 14 ++++++++++----
>   1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/locking/qspinlock_stat.h b/kernel/locking/qspinlock_stat.h
> index 72722334237a..ddcd653c942c 100644
> --- a/kernel/locking/qspinlock_stat.h
> +++ b/kernel/locking/qspinlock_stat.h
> @@ -225,12 +225,18 @@ static int __init init_qspinlock_stat(void)
>   	 * performance.
>   	 */
>   	for (i = 0; i<  qstat_num; i++)
> -		debugfs_create_file(qstat_names[i], 0400, d_qstat,
> -				   (void *)(long)i,&fops_qstat);
> +		if (!debugfs_create_file(qstat_names[i], 0400, d_qstat,
> +					 (void *)(long)i,&fops_qstat))
> +			goto fail;
> +
> +	if (!debugfs_create_file(qstat_names[qstat_reset_cnts], 0200, d_qstat,
> +				 (void *)(long)qstat_reset_cnts,&fops_qstat))
> +		goto fail;
>
> -	debugfs_create_file(qstat_names[qstat_reset_cnts], 0200, d_qstat,
> -			   (void *)(long)qstat_reset_cnts,&fops_qstat);
>   	return 0;
> +fail:
> +	debugfs_remove_recursive(d_qstat);
> +	return 1;
>   }
>   fs_initcall(init_qspinlock_stat);
>

Reviewed-by: Waiman Long <Waiman.Long@hpe.com>

Cheers,
Longman