Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752241AbcDRUQp (ORCPT ); Mon, 18 Apr 2016 16:16:45 -0400 Received: from mail-oi0-f53.google.com ([209.85.218.53]:35803 "EHLO mail-oi0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751558AbcDRUQl (ORCPT ); Mon, 18 Apr 2016 16:16:41 -0400 Date: Mon, 18 Apr 2016 15:16:39 -0500 From: Andy Gross To: Srinivas Kandagatla Cc: Greg Kroah-Hartman , linux-serial@vger.kernel.org, David Brown , Jiri Slaby , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] tty: msm_serial: remove static clk rate setting in probe Message-ID: <20160418201639.GA9967@hector.attlocal.net> References: <1457318800-26090-1-git-send-email-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1457318800-26090-1-git-send-email-srinivas.kandagatla@linaro.org> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1325 Lines: 38 On Mon, Mar 07, 2016 at 02:46:40AM +0000, Srinivas Kandagatla wrote: > The issue with setting up a fixed clock rate at probe is that it would > overwrite the console rate set by the bootloader for its console device. > This would result in serial out corruption or missing log when we system > is booted with earlycon. This is not a issue if we boot system without > earlycon. > > This setup is at least not required with the mainline driver, this code > used to be required because the clk_enable() call would fail if > clk_set_rate() wasn't called first. > > Originally the issue was noticed on DB410c which is based on APQ8016 > chipset. > > Without this patch the console log with earlycon would look like: > ... > [ 0.000000] RCU: Adjusting geometry for rcu_fanout_leaf=64, nr_cpu_ids=1 > [ 0.000000] NR_IRQS:64 nr_irqs:64 0 > ����+HH��0.699378] console [ttyMSM0] enabled > [ 0.699378] console [ttyMSM0] enabled > [ 0.702003] bootconsole [uart0] disabled > [ 0.702003] bootconsole [uart0] disabled > ... > > with this patch I can see all the skipped lines on the console > > Reviewed-by: Stephen Boyd > Signed-off-by: Srinivas Kandagatla Acked-by: Andy Gross Greg, Can you pick this one up? Thanks Andy