Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752157AbcDRUSM (ORCPT ); Mon, 18 Apr 2016 16:18:12 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:41761 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751671AbcDRUSK (ORCPT ); Mon, 18 Apr 2016 16:18:10 -0400 Subject: Re: [PATCH 2/8] writeback: add wbc_to_write_cmd() To: Jan Kara References: <1460953487-3430-1-git-send-email-axboe@fb.com> <1460953487-3430-3-git-send-email-axboe@fb.com> <20160418151242.GA28721@quack2.suse.cz> CC: , , , From: Jens Axboe Message-ID: <571540F9.1050904@fb.com> Date: Mon, 18 Apr 2016 16:18:01 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160418151242.GA28721@quack2.suse.cz> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.54.13] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-04-18_12:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 449 Lines: 16 On 04/18/2016 11:12 AM, Jan Kara wrote: > On Sun 17-04-16 23:24:41, Jens Axboe wrote: >> Add wbc_to_write_cmd(), which returns the write type to use, based on a >> struct writeback_control. No functional changes in this patch, but it >> prepares us for factoring other wbc fields for write type. >> >> Signed-off-by: Jens Axboe > > Looks good. You can add: > > Reviewed-by: Jan Kara Thanks Jan, added! -- Jens Axboe