Date: Mon, 18 Apr 2016 22:12:33 +0100
From: Matt Fleming <matt@codeblueprint.co.uk>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Will Deacon <will.deacon@arm.com>, Steve Capper <steve.capper@arm.com>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        David Daney <david.daney@cavium.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Leif Lindholm <leif.lindholm@linaro.org>,
        Dan Williams <dan.j.williams@intel.com>, linux-efi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] efi: ARM: avoid warning about phys_addr_t cast
Message-ID: <20160418211233.GZ2829@codeblueprint.co.uk>
References: <1460968481-169298-1-git-send-email-arnd@arndb.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1460968481-169298-1-git-send-email-arnd@arndb.de>
User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 887
Lines: 22

On Mon, 18 Apr, at 10:34:19AM, Arnd Bergmann wrote:
> memblock_remove() takes a phys_addr_t, which may be narrower than 64 bits,
> causing a harmless warning:
> 
> drivers/firmware/efi/arm-init.c: In function 'reserve_regions':
> include/linux/kernel.h:29:20: error: large integer implicitly truncated to unsigned type [-Werror=overflow]
>  #define ULLONG_MAX (~0ULL)
>                     ^
> drivers/firmware/efi/arm-init.c:152:21: note: in expansion of macro 'ULLONG_MAX'
>   memblock_remove(0, ULLONG_MAX);
> 
> This adds an explicit typecast to avoid the warning
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 500899c2cc3e ("efi: ARM/arm64: ignore DT memory nodes instead of removing them")
> ---
>  drivers/firmware/efi/arm-init.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Will, this one is for you.

Reviewed-by: Matt Fleming <matt@codeblueprint.co.uk>