Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752030AbcDSCCD (ORCPT ); Mon, 18 Apr 2016 22:02:03 -0400 Received: from mail-yw0-f177.google.com ([209.85.161.177]:36280 "EHLO mail-yw0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751520AbcDSCCB (ORCPT ); Mon, 18 Apr 2016 22:02:01 -0400 MIME-Version: 1.0 In-Reply-To: References: <50b61ce23a73b68c3c55d6d9aa416af29001205a.1438170155.git.baolin.wang@linaro.org> Date: Tue, 19 Apr 2016 10:02:00 +0800 Message-ID: Subject: Re: [RESEND PATCH v2 3/5] security: Introduce security_settime64() From: Baolin Wang To: John Stultz Cc: Serge Hallyn , James Morris , "Serge E. Hallyn" , Thomas Gleixner , Paul Moore , Stephen Smalley , Kees Cook , John Johansen , casey@schaufler-ca.com, agruenba@redhat.com, Alexander Viro , Neil Brown , jann@thejh.net, Mark Brown , Christopher Hall , Xunlei Pang , Harald Geyer , Arnd Bergmann , lkml , LSM List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1184 Lines: 39 On 19 April 2016 at 00:54, John Stultz wrote: > On Thu, Apr 7, 2016 at 11:02 PM, Baolin Wang wrote: >> security_settime() uses a timespec, which is not year 2038 safe >> on 32bit systems. Thus this patch introduces the security_settime64() >> function with timespec64 type. We also convert the cap_settime() helper >> function to use the 64bit types. >> >> Move the security_settime() to the head file as a inline function for >> removing that inline helper when following up patches are fixed the >> call sites. >> >> None of the existing hooks is using the timespec argument and therefor >> the patch is not doing any functional changes. >> >> Signed-off-by: Baolin Wang > > Hey Baolin, > If you get an ack, like you did from James, please include it in the > commit message of following submissions Ah, sorry, I forgot that. Do I need to resend it with James ack? Thanks. > > Serge, Kees: Any objection to this patch going in via the > tip/timers/core tree with the dependent settimeofday64 call? > > Otherwise I'll queue this up for testing. > > thanks > -john > > > . -- Baolin.wang Best Regards