Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752381AbcDSCev (ORCPT ); Mon, 18 Apr 2016 22:34:51 -0400 Received: from nat-hk.nvidia.com ([203.18.50.4]:45360 "EHLO hkmmgate102.nvidia.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751650AbcDSCet convert rfc822-to-8bit (ORCPT ); Mon, 18 Apr 2016 22:34:49 -0400 X-PGP-Universal: processed; by hkpgpgate101.nvidia.com on Mon, 18 Apr 2016 19:34:46 -0700 Message-ID: <5715998B.6080607@nvidia.com> Date: Tue, 19 Apr 2016 10:35:55 +0800 From: Wei Ni User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Thierry Reding , Arnd Bergmann CC: Eduardo Valentin , Zhang Rui , Stephen Warren , Alexandre Courbot , Jon Hunter , , , Subject: Re: [PATCH] thermal: tegra: mark PM functions __maybe_unused References: <1460838026-1242452-1-git-send-email-arnd@arndb.de> <20160418071513.GA13078@ulmo.ba.sec> In-Reply-To: <20160418071513.GA13078@ulmo.ba.sec> X-Originating-IP: [10.19.224.146] X-ClientProxiedBy: DRBGMAIL101.nvidia.com (10.18.16.20) To HKMAIL102.nvidia.com (10.18.16.11) Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1249 Lines: 40 On 2016年04月18日 15:15, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Sat, Apr 16, 2016 at 10:19:33PM +0200, Arnd Bergmann wrote: >> After the PM support has been added to this driver, we get >> a harmless warning when that support is disabled at compile >> time: >> >> drivers/thermal/tegra/soctherm.c:641:12: error: 'soctherm_resume' defined but not used [-Werror=unused-function] >> static int soctherm_resume(struct device *dev) >> >> This marks the two PM functions as __maybe_unused to shut up >> the warning. This is preferred over adding an #ifdef around >> them, as it is harder to get wrong, and provides better >> compile-time coverage. >> >> Signed-off-by: Arnd Bergmann >> Fixes: a134b4143b65 ("thermal: tegra: add PM support") >> --- >> drivers/thermal/tegra/soctherm.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > The need for this should go away when Jon's generic power domain series Hi Thierry, Could you please show me the Jon's generic power domain series, so that I can verify it. Thanks. > gets merged (hopefully very soon now) and enabled on 32-bit ARM. In the > meantime: > > Acked-by: Thierry Reding > > * Unknown Key > * 0x7F3EB3A1 >