From: Po Liu <po.liu@nxp.com>
To: Mark Brown <broonie@kernel.org>, Scott Wood <scott.wood@nxp.com>
CC: "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Yao Yuan <yao.yuan@nxp.com>
Subject: RE: [PATCH] dspi: config dspi master regmap with right mode depend on
 BE or LE
Thread-Topic: [PATCH] dspi: config dspi master regmap with right mode depend
 on BE or LE
Thread-Index: AQHRlXVj4SR4p/hUykKzGp2joAqiCJ+Pil+AgAERYnA=
Date: Tue, 19 Apr 2016 02:30:50 +0000
Message-ID: <VI1PR0401MB17091173636FAB61369B5ADE926C0@VI1PR0401MB1709.eurprd04.prod.outlook.com>
References: <1460545402-8162-1-git-send-email-po.liu@nxp.com>
 <DB5PR0401MB19281A317BFB1D9001F97ABB916A0@DB5PR0401MB1928.eurprd04.prod.outlook.com>
 <20160418101117.GP3217@sirena.org.uk>
In-Reply-To: <20160418101117.GP3217@sirena.org.uk>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:23
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2016 02:30:50.4131
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB1933
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u3J34d9v024161
Content-Length: 1479
Lines: 35

Hi Mark and Scott,

Thank you very much both!
The default dspi in the .dtsi setting to be Big endian as default. But it will hang at cpu setting big endian mode. After setting _format_endian = REGMAP_ENDIAN_LITTLE will fix it only in big endian mode.

We'll check it more about the val_format_endian_default.


Best regards,
Liu Po


Best regards,
Liu Po

EXT:8038


-----Original Message-----
From: Mark Brown [mailto:broonie@kernel.org] 
Sent: Monday, April 18, 2016 6:11 PM
To: Scott Wood
Cc: Po Liu; linux-spi@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dspi: config dspi master regmap with right mode depend on BE or LE

On Sun, Apr 17, 2016 at 02:41:40AM +0000, Scott Wood wrote:

> Looking more closely, the binding has a big-endian property.  It says 
> the default if that property is absent is native endian, which is 
> insane.  Fix the binding to say that little endian is the default 
> (this change shouldn't break any existing trees), and make sure that's 
> what the code implements.  I think you need val_format_endian_default, 
> not val_format_endian.

The binding defaults to little endian and (in implmentation terms) always has done though that used to be unintentional.  There *are* a reasonable number of devices out there which are native endian, for example most of the MIPS chips switch the endianness of the entire chip rather than just the CPU, but most of the current usage has been on ARM devices which only switch the core.