Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752703AbcDSHlo (ORCPT ); Tue, 19 Apr 2016 03:41:44 -0400 Received: from 7of9.schinagl.nl ([88.159.158.68]:56726 "EHLO 7of9.schinagl.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751938AbcDSHln (ORCPT ); Tue, 19 Apr 2016 03:41:43 -0400 From: Olliver Schinagl To: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Richard Purdie , Jacek Anaszewski Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, Olliver Schinagl Subject: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups Date: Tue, 19 Apr 2016 09:40:44 +0200 Message-Id: <1461051650-18824-1-git-send-email-oliver@schinagl.nl> X-Mailer: git-send-email 2.8.0.rc3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1240 Lines: 28 Using the pca963x for a while, I noticed something that may look like some i2c accessing issues where sometimes data was incorrectly written to the bus, possibly because we where not properly locking the i2c reads. Though I'm not familiar enough with the i2c framework to be certain reads need to be locked at all. A patch was added to properly lock i2c access more tightly. Furthermore there was no method to support inverted outputs. This series adds a property to the device tree to inform the driver that the output is inverted (active-high vs active-low). Additionally, this patch set does some cleanups to please checkpatch, and removes a few magic values. Olliver Schinagl (6): leds: pca963x: Alphabetize headers leds: pca963x: Lock i2c r/w access leds: pca963x: Add defines and remove some magic values leds: pca963x: Reduce magic values leds: pca963x: Inform the output that it is inverted leds: pca963x: Remove whitespace and checkpatch problems Documentation/devicetree/bindings/leds/pca963x.txt | 1 + drivers/leds/leds-pca963x.c | 243 ++++++++++++++------- include/linux/platform_data/leds-pca963x.h | 1 + 3 files changed, 171 insertions(+), 74 deletions(-) -- 2.8.0.rc3