Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751831AbcDSH7D (ORCPT <rfc822;w@1wt.eu>);
	Tue, 19 Apr 2016 03:59:03 -0400
Received: from gloria.sntech.de ([95.129.55.99]:39322 "EHLO gloria.sntech.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751897AbcDSH7B (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 19 Apr 2016 03:59:01 -0400
From: Heiko =?ISO-8859-1?Q?St=FCbner?= <heiko@sntech.de>
To: Mark Yao <mark.yao@rock-chips.com>
Cc: David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>
Subject: Re: [PATCH 2/2] dt-bindings: add document for rk3399-vop
Date: Tue, 19 Apr 2016 09:58:52 +0200
Message-ID: <6435836.sTKjWLANC0@diego>
User-Agent: KMail/4.14.10 (Linux/4.4.0-1-amd64; KDE/4.14.14; x86_64; ; )
In-Reply-To: <1460949478-2236-2-git-send-email-mark.yao@rock-chips.com>
References: <1460949478-2236-1-git-send-email-mark.yao@rock-chips.com> <1460949478-2236-2-git-send-email-mark.yao@rock-chips.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1509
Lines: 40

patch subject above:
dt-bindings: add documentation for Rockchip rk3399 display controllers

not everybody skimming over patches directly knows what a vop is ;-)

I still believe even such a trivial patch should also get some form of 
description, something like:

---------
Document compatible values for rk3399 display controllers.
Big and little display controllers are not identical and have differing 
feature sets on the rk3399.
---------

> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
> Cc: Kumar Gala <galak@codeaurora.org>
> 
> Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
> ---
>  .../bindings/display/rockchip/rockchip-vop.txt     |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git
> a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt index
> 5489b59..fd25ea9 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> @@ -8,6 +8,8 @@ Required properties:
>  - compatible: value should be one of the following
>  		"rockchip,rk3288-vop";
>  		"rockchip,rk3036-vop";
> +		"rockchip,rk3399-vop-big";
> +		"rockchip,rk3399-vop-lit";
> 
>  - interrupts: should contain a list of all VOP IP block interrupts in the
>  		 order: VSYNC, LCD_SYSTEM. The interrupt specifier