Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753341AbcDSI6A (ORCPT ); Tue, 19 Apr 2016 04:58:00 -0400 Received: from s3.sipsolutions.net ([5.9.151.49]:48885 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753294AbcDSI55 (ORCPT ); Tue, 19 Apr 2016 04:57:57 -0400 Message-ID: <1461056272.2766.8.camel@sipsolutions.net> Subject: Re: [PATCH v3] prism54: isl_38xx: Replace 'struct timeval' From: Johannes Berg To: Arnd Bergmann Cc: Tina Ruchandani , y2038@lists.linaro.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, "Luis R. Rodriguez" Date: Tue, 19 Apr 2016 10:57:52 +0200 In-Reply-To: <4679823.7bDEQhE9qO@wuerfel> References: <20160413060916.GA21184@localhost> <5521267.mr5HLCdTY6@wuerfel> <1460896953.15362.2.camel@sipsolutions.net> <4679823.7bDEQhE9qO@wuerfel> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 654 Lines: 19 On Mon, 2016-04-18 at 00:10 +0200, Arnd Bergmann wrote: > On Sunday 17 April 2016 14:42:33 Johannes Berg wrote: > > > > > > I was thinking more restrictively of just the stuff that can't even > > be > > built without modifying the sources - like the "#if VERBOSE" thing. > All the DEBUG() statements are inside of this kind of check, so if we > remove the #ifdefs, it would be logical to remove the rest of the > debugging infrastructure (DEBUG() macros, SHOW_*, pc_debug, maybe > more) as well. > Seems reasonable. Maybe we should Cc the maintainer, but I suspect that since the driver is marked Obsolete anyway Luis won't care either :) johannes