Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753530AbcDSJbu (ORCPT ); Tue, 19 Apr 2016 05:31:50 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:6770 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752162AbcDSJbs (ORCPT ); Tue, 19 Apr 2016 05:31:48 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Tue, 19 Apr 2016 02:28:48 -0700 Subject: Re: [PATCH v3 1/2] i2c: tegra: add separate function for config_load To: Shardar Shariff Md , , , , , , , , References: <1460985355-28901-1-git-send-email-smohammed@nvidia.com> From: Jon Hunter Message-ID: <5715FAFD.2070303@nvidia.com> Date: Tue, 19 Apr 2016 10:31:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1460985355-28901-1-git-send-email-smohammed@nvidia.com> X-Originating-IP: [10.21.132.108] X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1559 Lines: 44 On 18/04/16 14:15, Shardar Shariff Md wrote: > - Define separate function for configuration load register handling > to make it use by different functions later. > - Instead of calculating timeout for the config load during init, > calculate it when config load register is written. Also use the > msecs_to_jiffies for timeout calculation instead of macro HZ. > > Signed-off-by: Shardar Shariff Md > > Changes since v1: > - Add separate function for config load handling > --- > drivers/i2c/busses/i2c-tegra.c | 39 +++++++++++++++++++++++++-------------- > 1 file changed, 25 insertions(+), 14 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c > index d764d64..6235f16 100644 > --- a/drivers/i2c/busses/i2c-tegra.c > +++ b/drivers/i2c/busses/i2c-tegra.c > @@ -423,12 +423,31 @@ static inline void tegra_i2c_clock_disable(struct tegra_i2c_dev *i2c_dev) > clk_disable(i2c_dev->fast_clk); > } > > +static int tegra_i2c_wait_for_config_load(struct tegra_i2c_dev *i2c_dev) > +{ > + unsigned long timeout; > + > + if (i2c_dev->hw->has_config_load_reg) { > + i2c_writel(i2c_dev, I2C_MSTR_CONFIG_LOAD, I2C_CONFIG_LOAD); > + timeout = jiffies + msecs_to_jiffies(1000); > + while (i2c_readl(i2c_dev, I2C_CONFIG_LOAD) != 0) { > + if (time_after(jiffies, timeout)) { > + dev_warn(i2c_dev->dev, > + "timeout waiting for config load\n"); > + return -ETIMEDOUT; > + } > + msleep(1); > + } How about using the readx_poll_timeout() (include/linux/iopoll.h) here? Cheers Jon