Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753210AbcDSJj6 (ORCPT ); Tue, 19 Apr 2016 05:39:58 -0400 Received: from 7of9.schinagl.nl ([88.159.158.68]:45790 "EHLO 7of9.schinagl.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752760AbcDSJj4 (ORCPT ); Tue, 19 Apr 2016 05:39:56 -0400 Subject: Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups To: Jacek Anaszewski References: <1461051650-18824-1-git-send-email-oliver@schinagl.nl> <5715F927.3030102@samsung.com> Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Richard Purdie , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, Peter Meerwald , Ricardo Ribalda Delgado From: Olliver Schinagl Message-ID: <5715FCE8.7080106@schinagl.nl> Date: Tue, 19 Apr 2016 11:39:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <5715F927.3030102@samsung.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1700 Lines: 47 On 19-04-16 11:23, Jacek Anaszewski wrote: > Hi Olliver, > > Thanks for the patches. > Adding driver authors on cc. Ah sorry about that, thanks. I guess get_maintainers doesn't do that. As for the compile bug, I'll fix that with v2, it only applies on the intermediate patches, not on the whole set. Olliver > > On 04/19/2016 09:40 AM, Olliver Schinagl wrote: >> Using the pca963x for a while, I noticed something that may look like >> some >> i2c accessing issues where sometimes data was incorrectly written to >> the bus, >> possibly because we where not properly locking the i2c reads. Though >> I'm not >> familiar enough with the i2c framework to be certain reads need to be >> locked >> at all. A patch was added to properly lock i2c access more tightly. >> >> Furthermore there was no method to support inverted outputs. This series >> adds a property to the device tree to inform the driver that the output >> is inverted (active-high vs active-low). >> >> Additionally, this patch set does some cleanups to please checkpatch, >> and >> removes a few magic values. >> >> Olliver Schinagl (6): >> leds: pca963x: Alphabetize headers >> leds: pca963x: Lock i2c r/w access >> leds: pca963x: Add defines and remove some magic values >> leds: pca963x: Reduce magic values >> leds: pca963x: Inform the output that it is inverted >> leds: pca963x: Remove whitespace and checkpatch problems >> >> Documentation/devicetree/bindings/leds/pca963x.txt | 1 + >> drivers/leds/leds-pca963x.c | 243 >> ++++++++++++++------- >> include/linux/platform_data/leds-pca963x.h | 1 + >> 3 files changed, 171 insertions(+), 74 deletions(-) >> > >