Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753684AbcDSJzy (ORCPT ); Tue, 19 Apr 2016 05:55:54 -0400 Received: from e28smtp04.in.ibm.com ([125.16.236.4]:48129 "EHLO e28smtp04.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753649AbcDSJzv (ORCPT ); Tue, 19 Apr 2016 05:55:51 -0400 X-IBM-Helo: d28relay08.in.ibm.com X-IBM-MailFrom: akshay.adiga@linux.vnet.ibm.com X-IBM-RcptTo: linux-pm@vger.kernel.org;linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] cpufreq: powernv: Ramp-down global pstate slower than local-pstate To: Viresh Kumar References: <1460701739-31549-1-git-send-email-akshay.adiga@linux.vnet.ibm.com> <1460701739-31549-3-git-send-email-akshay.adiga@linux.vnet.ibm.com> <20160418101846.GB2322@vireshk-i7> Cc: rjw@rjwysocki.net, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, ego@linux.vnet.ibm.com From: Akshay Adiga Message-ID: <5716009C.8050704@linux.vnet.ibm.com> Date: Tue, 19 Apr 2016 15:25:40 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160418101846.GB2322@vireshk-i7> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable x-cbid: 16041909-0013-0000-0000-00000BD22913 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1507 Lines: 42 Hi Viresh, On 04/18/2016 03:48 PM, Viresh Kumar wrote: > On 15-04-16, 11:58, Akshay Adiga wrote: >> static int powernv_cpufreq_reboot_notifier(struct notifier_block *nb, >> - unsigned long action, void *unused) >> + unsigned long action, void *unused) > Unrelated change.. better don't add such changes.. Posting out v3 with out this unrelated change. >> { >> int cpu; >> struct cpufreq_policy cpu_policy; >> @@ -603,15 +843,18 @@ static struct notifier_block powernv_cpufreq_opal_nb = { >> static void powernv_cpufreq_stop_cpu(struct cpufreq_policy *policy) >> { >> struct powernv_smp_call_data freq_data; >> - >> + struct global_pstate_info *gpstates = policy->driver_data; > You removed a blank line here and I feel the code looks better with > that. > >> freq_data.pstate_id = powernv_pstate_info.min; >> + freq_data.gpstate_id = powernv_pstate_info.min; >> smp_call_function_single(policy->cpu, set_pstate, &freq_data, 1); >> + del_timer_sync(&gpstates->timer); >> } >> >> static struct cpufreq_driver powernv_cpufreq_driver = { >> .name = "powernv-cpufreq", >> .flags = CPUFREQ_CONST_LOOPS, >> .init = powernv_cpufreq_cpu_init, >> + .exit = powernv_cpufreq_cpu_exit, >> .verify = cpufreq_generic_frequency_table_verify, >> .target_index = powernv_cpufreq_target_index, >> .get = powernv_cpufreq_get, > None of the above comments are mandatory for you to fix.. > > Acked-by: Viresh Kumar > Thanks for Ack :)