Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753613AbcDSKmT (ORCPT ); Tue, 19 Apr 2016 06:42:19 -0400 Received: from mail-io0-f170.google.com ([209.85.223.170]:34924 "EHLO mail-io0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753217AbcDSKmS (ORCPT ); Tue, 19 Apr 2016 06:42:18 -0400 MIME-Version: 1.0 In-Reply-To: <1461054788-339-3-git-send-email-van.freenix@gmail.com> References: <1461054788-339-1-git-send-email-van.freenix@gmail.com> <1461054788-339-3-git-send-email-van.freenix@gmail.com> Date: Tue, 19 Apr 2016 07:42:17 -0300 Message-ID: Subject: Re: [PATCH 3/3] nvmem: imx-ocotp: handling clock From: Fabio Estevam To: Peng Fan Cc: Shawn Guo , Srinivas Kandagatla , Maxime Ripard , "devicetree@vger.kernel.org" , linux-kernel , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 431 Lines: 12 Hi Peng, On Tue, Apr 19, 2016 at 5:33 AM, Peng Fan wrote: > @@ -46,11 +48,15 @@ static int imx_ocotp_read(void *context, const void *reg, size_t reg_size, > if (count > (priv->nregs - index)) > count = priv->nregs - index; > > + clk_prepare_enable(priv->clk); clk_prepare_enable() may fail, so you should better check its return value and propagate it in the case of error.