Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753639AbcDSMY6 (ORCPT ); Tue, 19 Apr 2016 08:24:58 -0400 Received: from mail-bl2on0057.outbound.protection.outlook.com ([65.55.169.57]:42604 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752766AbcDSMY4 (ORCPT ); Tue, 19 Apr 2016 08:24:56 -0400 Authentication-Results: spf=pass (sender IP is 63.163.107.21) smtp.mailfrom=sandisk.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac160c69-5f3ff70000000be7-03-571623399243 Subject: Re: [PATCH] irq_poll: Remove redundant barrier when using clear_bit_unlock() To: Davidlohr Bueso References: <1460829336-6146-1-git-send-email-dave@stgolabs.net> CC: "linux-kernel@vger.kernel.org" , "Davidlohr Bueso" From: Bart Van Assche Message-ID: <5716238D.6040308@sandisk.com> Date: Tue, 19 Apr 2016 08:24:45 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1460829336-6146-1-git-send-email-dave@stgolabs.net> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrELMWRmVeSWpSXmKPExsWyRoxnka6lsli4Qe8hKYvVN9cwWkzbMoHR 4vKuOWwOzB5TZ9d7bD5d7fF5k1wAcxSXTUpqTmZZapG+XQJXxo6rhgVfmSoOH7nB1sC4iKmL kZNDQsBE4v+5z8xdjFwcQgJzmSQ2PFjOAuHsYJRYsHYpK0xVy9b3TBCJpYwS6/pOMoIkhAXC Jf5OmccGYosIqEvMW3sbLC4k4CDR/vQtO4jNLJAq8fDnUbBBbAJGEt/ez2QBsXkFtCTetG4E q2cRUJVoeHsHbI6oQITE6nXXmCFqBCVOznwCVs8p4Cix6c57ZoiZFhIz559nhLDlJba/nQP2 goRAH6vExOY7rBBHqEucXDKfaQKj8Cwks2Yh6Z+FpH8BI/MqRrHczJzi3PTUAkNTveLEvJTM 4my95PzcTYyQkM/cwXj3ifchRgEORiUe3oAC0XAh1sSy4srcQ4wSHMxKIrzdCmLhQrwpiZVV qUX58UWlOanFhxilOViUxHnd7n0JExJITyxJzU5NLUgtgskycXBKNTDm3m+q3PC/YdPkQ6ae yc0XeGvY6pr/VMv0cLgkxb28srX4X3jzvscnZl079HtnX40qj6tw3RqR9TI7Zosdz5vGcSL/ ++3VcW3T2ReZ/ZxfIVR9rUmzI//0TCUxhumFht76/Z/dEtRul03/eerXb96Ya5OKUhTefSs9 1H7p6+mzDsflm8wXcC9VYinOSDTUYi4qTgQA9JNWvHUCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGJMWRmVeSWpSXmKPExsXCtZEjRbdPWSzc4PV+bYvVN9cwWkzbMoHR 4vKuOWwOzB5TZ9d7bD5d7fF5k1wAcxSXTUpqTmZZapG+XQJXxo6rhgVfmSoOH7nB1sC4iKmL kZNDQsBEomXrezBbSGAxo8Sfb2EgtrBAuMTfKfPYQGwRAXWJeWtvM0LUOEi0P33LDmIzC6RK 3Lz2FMxmEzCS+PZ+JguIzSugJfGmdSNYPYuAqkTD2ztgc0QFIiRWr7vGDFEjKHFy5hOwek4B R4lNd94zQ8w0k5i3+SGULS+x/e0c5gmMfLOQtMxCUjYLSdkCRuZVjGK5mTnFuemZBYaGesWJ eSmZxdl6yfm5mxjBIccZuYPx6UTzQ4xMHJxSDYytOcerlOZpRZ++2hL4bELF4Yl8+1Zcmrhk i+gjvqgJ64XYW+Q+6m/nKlBd0x5iMmvjy1+VD+pWegV+mGQvaf/s5F1xk6nbvv0xSswK27Fe fTn/cf6V5w7NrJrTaNK3dOu3ttpNRad27/gS1226pv/wpz0nLJTVewJmRRqrzWYUDlo3zWXJ ht7VSizFGYmGWsxFxYkA2Ryb6OkBAAA= X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:63.163.107.21;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(189002)(199003)(24454002)(377454003)(36756003)(76176999)(54356999)(87266999)(23676002)(53416004)(65816999)(11100500001)(50986999)(83506001)(59896002)(80316001)(86362001)(5008740100001)(230700001)(81166005)(50466002)(64126003)(6806005)(99136001)(189998001)(77096005)(92566002)(110136002)(2906002)(87936001)(65956001)(47776003)(106466001)(33656002)(1096002)(5003600100002)(4326007)(2950100001)(586003)(1220700001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR0201MB1934;H:milsmgep15.sandisk.com;FPR:;SPF:Pass;MLV:sfv;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD036;1:XxXnIRHsLTET8tYDDf689IxSvYm3HU03QHhR8M+uvmZS0mVObvm5ehRMs54LqLqHBco3qg5cMP7lcklF0jatGNdtNz0kzfSEIxhkE4gA7OoLAJRSSnx/cJGpLCji7CoDHsum4x8teFhwUR5Oeld/u8tXZSv2rdS3R2hRigLMUUzg6kph91ZXZEGENwP/xEX4FvjDZ8x8QI0M6PUwVrsgZFbyWaYhSoIp0IlMHYEbBcJn+1rl4OMpeLkE9kAnrEhHaLI9Ojr4brQolP1VrghO2npfyfOTjkdt0rour/2tXER0vbe9aJSrA7ZYepVpmbQ6AQKotcrhzjyvyxKIrRqIyawOEXplawHIUwn4ArnvpK+7CUCQ4H4JUDkHf+IhugsYMTTaddZJ9pzD7AYYbxqVe05MWpqB1zQQyeLBSsz5qPGvGP36ZyaMtBWe9oajpJX+5S1g39N26H1GgE2JQIWdjKolEOJBrF7Ua1uc+Aoj85M= X-MS-Office365-Filtering-Correlation-Id: ddc4bbcb-252a-402f-7c2e-08d3684d98d5 X-Microsoft-Exchange-Diagnostics: 1;SN1PR0201MB1934;2:xKl3rJONoAwzfMpB3E4iTsIwB1PE1jUgFUIqFZ5sA7V3ciIKCiK3/UgO2U9G3RS+Kw1pnR05u9+L2m7CNBLa2BsT3iBJ1FA9eQZKXasKKyLM/IA/hcQ/X/rokd1KdhLW/AUW/AucJLcaXSjd+kiy3284jE/5FUj9O/HCfk7Viv374xGG49T0vPwRnf/WoQIc;3:OM5MUT/Xb1yF4/zQMKsT2iFiMhM2sf+JCQ0gDOPMkgmnjLUNWd6MEQ4xvXeQ+WDFuq7lcs9GKiPX/QPbucbpyGEoDgKsKNicSWupWtoBper9TP2E/uIPil8uo/0hAlMipMLBt6nmO4HNuGbct8HPUeMGe/0c3G6wcpgGnVdBsTJCdmbp3Z2W6YV13ks2ElwrczNx9JHz//XicNA8J2xjpMxPK29dNVrP8HryHcFtYSuNk+2s6pVKrKpVrVCR9mDvdYjWv81zkTlIlgg8S9D/+g==;25:h4Q8vY1cM/2cVsDkBPfH1Rkeq3cC/zfm/Di1bG6axOwXH13lqbCjvAycZ5kxDWozxU0gkoHuquA/QYvpSNqThzUlEzCiQ6JC16ONjq8b78kvAVdGmKIdNtKW4C+XkUYwc7dN1Sg0rh7OSoqm8HwRGF1QRpivdV7tKMLW5YPW4v9/YPTA5Y8qr4vc8tMD3ZZYwnrhB1R/Cas0egO6L82kGBTqeVZe2JI4geY5cend7bWEKmBXQ72tFGotGeDqxI4ahic9EKMVbYa8Xxni54DcwEPCjho0q1asbq/yq9NHtcqSa20HpB+fgCXV/qBlq+A9AD58vJyVMTwziPQ0eaZ/9A== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:SN1PR0201MB1934; X-Microsoft-Exchange-Diagnostics: 1;SN1PR0201MB1934;20:HAXrY0qp3sd0GhPgV/QZhFn2umbBXYNMMr2sxAYDz1Qvl6wlwtGVJ95kxmjcuIQLVBZONk5cuV2RpkM79mAPrMGCFtOeRMff930JbxTj7HFet8LNk6NhlktiBdPsr6Pf/1jQpzJjDyT+b05ScE1yjq+K+o+RK+VvjAiP1Ldph2vtRBDiONu5AEFEbGiRQVxfXamJNTqojqMHslYyHAS02Z+u/9RUYDHganhVlU0LP1ITxeyf363pJvgia8e3OntaC0f/7WzSKQKyCByXUKSEFWcRp03zdH593nvXUsrfI2R9nt2cZDp2MNA3NkPPdGYMllCMCD8xEDlkklZL7dOuewjYt+/EJqEnbrFlONBhpdVTf0wRuNp2PHlqDNFaHu6zoWW0D4SqUG3WDfqn3pZUC98ND5AA+QhV980n1kirCSjRC1O+CgDY6XnQHSLPeFqjp1/GXthE0cUwTIbMvE1nq7la/Yb9oVrvFCaC93Bwwzn4lel8rqrr9TmT9x3j7cUw;4:QSs93K2Ok848wIGj44NUlimZYdOGBmfqQLGewbSvJj1ZReGZer35kkTy0UzlizgtPQ/XungQIWSWCk/rLlzh1YA+7DZr2VkCqewznaA4/v/YtntfqAIZ9mCBQbfAEwzG46QNN75B47GnOOlVEn+/VNG+rxaQPJuI1xaz93CZFkq/5v5gTheWUc+r1MVSHZr8YP2zZ2VsG0hiwZekqMKALLtH4cqmm6D/E2jzLUSjUm1tupZ81jEml+WiwP7pAUptFfJV5SrSZNmlqT1OZWrD+IJNL90FU4hlo2+0rJxR+41Br8HCeJp3uB48VH5DJy7pUuh1GAj2OwJ3iZDVRtMNH7Wnw/L6nz9OHtvbXhlCGasKLA0we3SK8xWshbzKS+1J4drsvTCO0yXUiduySZQiYcyD9dPdzSdUQNmNTzW4P9NvVlm6yYF936qt4GRn37Fy X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(9101521026)(601004)(2401047)(8121501046)(13018025)(13016025)(5005006)(10201501046)(3002001);SRVR:SN1PR0201MB1934;BCL:0;PCL:0;RULEID:;SRVR:SN1PR0201MB1934; X-Forefront-PRVS: 0917DFAC67 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjAyMDFNQjE5MzQ7MjM6ZENIWXMyUW5NU3FGd1BDdUYvaGRPS3Rp?= =?utf-8?B?NUg2d0VobmtEeWFuTXZ5alpwczJlRnF5TkRHUG1pUC9MaGRIb2NhMlJoSWgv?= =?utf-8?B?QjhDdVNtdWorYmVrd2RHd1dDUytXeURYcWN2Q0dwQS9JeHc5M01lSEJ0K2ZK?= =?utf-8?B?Y3kvaGR5S1Q4VXg4TUw3RDJ2WnB6bHAybFE3ZzRJYmVHcGkrdnhybm5BNFVK?= =?utf-8?B?STY5TlMwNzVKMDEzS2VMMFZRNXVYNzRrbE9UbzV2SnY1NUhRMVlCbjRYY2pH?= =?utf-8?B?MFJjQ0crZkpvUjN6ZWVoMWErcE5Lc25rU1ZkTXpYOVdHVU52VEx4a0U4Ri9O?= =?utf-8?B?a1BDdk5jZHI0eTE2YmRMRzcyY1hEbkNMTFNnZHJNaTdBcThaTHphUHVMazdJ?= =?utf-8?B?c1VvSHFtVnR4dFRWc0g5bjlCTVFaMU5yL3VWRkRLYkdkS0s1TmMzODl2STMy?= =?utf-8?B?bVNKVElvYVd3Q0VxVThxcFc2QXNuZWYycXQyRkdoZDBRbis2ZVMwWkcrU1Nw?= =?utf-8?B?VDF1NWtnNUlqZTZNSmlwMW9IVVZQWk9JT1RFTnNYSkZIVUlCSDNqZTNLdUps?= =?utf-8?B?dk9zOWlqMlk5L2Rqazc2THpKd05mcmUzVHVkNGd3WEYzT2UzOHgrVVNkWVND?= =?utf-8?B?NVV1L1pyTDB1TWVDbVJOTnJBemZ0NGppQW9LZUxiL2MxYTJJVUZtVjU3UzFW?= =?utf-8?B?S0F6bkZMTXdKQW0weWpyc0dXaTRxZWZwSjd5cG9lTVoydWtEZXdmd3U0SFNw?= =?utf-8?B?cFZ5Z1l3bTdLWitoTjRJaXU3emRoclVLenlCVFJUZGg0bEovTktFYUR3ZHJx?= =?utf-8?B?c3V0QWROYndNR21mdHhBRGFpVjJoRWpORm42bEcwOWpjSkNUQkd4aHJoY3dV?= =?utf-8?B?dlFOdUFqMm4ybWYxSUNwMXhlMUVBdnpGK2JxNUg4alpnYlF0MHQ3ZkVqdW95?= =?utf-8?B?SjdTQllDM2Q4RVJ4Uy9sOVREbTRuM3pUaDhKRStHbFczRVM5SFdDTlZLL3gz?= =?utf-8?B?MVA5aE82MXVpWGpZNTkvVmJYNzFleHUxNGQwMkIzYmJqMmh6aEF5aEhheStZ?= =?utf-8?B?WWdPY1h0RjN1MG1VcHIrNE5qNzhqRXRnUHZobTYwMHI3NGxvNGp5NnZ0bElx?= =?utf-8?B?YU1Yajlnd2w3WlhXbEZUdW1Od1JRWkU5aWJJdmpHZjB5MGRJY3dyZ2pjY0ZS?= =?utf-8?B?c0gzQVhRQ3g4cmZPbFBBVUE5amRoOGowOHJWYm8vMmtGWUhBRnJWM2dlSDFT?= =?utf-8?B?YW1hUjF3dXlPa1piY0JEQmJMT3E2YWFSektiQVQzWW9WQkJlVHRkMDhzeGdh?= =?utf-8?B?V0ljVlhqM3RWM05wV1hIRzNYQm1ETDhHb1IwblNCUEpWNzBiNTFxODFXakVh?= =?utf-8?B?Ni9tMHRkWXY5NXFhbmQ0TXphanQ1YjB3TDVtbm1lVkpqeFJoak1veUI1Rk1h?= =?utf-8?B?WE03eW4xZ1dkR3VsQ21vWTEvMUsrblZXNWF5STJNU3ZmYTlObHJiZnREOXpi?= =?utf-8?B?UjZicW5nPT0=?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR0201MB1934;5:yYnjCWbGOmiTit0gKdwC+Jyde7q4d//tQpmQOHp07EFq+5YuKx+QXxTI/BgZqm2x9MFPNSZA+WNbazU/Fac7khkUkMQgMFw72TUTpewKn7P4n53e0c6VCNkHL1wI6XWylgdfA9JueCqYP4jJrS6bTgwcCDa04OAXlt/Ur9LsjshJvxr52URhIcW1vz/CmffK;24:CBgGmFMSW7tSTkEO5Qpr9EAl9S3R2loa8j6SIe9rVEBfZqzls8hyBhOMKbeUprELUvHpNvHp/tbC06wQPjOnN4UWfsh0YATNVKnU3XoJoHg=;7:cvbGZFCUYTzxSeeiJK6WD/k7MnjohSFPgEbam9sP0HBvRCyAewHl6s7BztEl8ELEPytSVZhV9ufvMp7jeLhNBHRiRnAy+Cx9wSBpUxVjLh18AHclm/HldqwQ4JHx0+SzzyDWV49YQtEa41U/hRYwxeQJC1/J/D+MFbNFmdqU6JbqpK0/5F6BTAtOKNnqLR0auoi3rb33hSDrySttk7Mq5GVEscPuebw+Je8VLcw+Sb0=;20:qmzgPZ4hb7sBpOa0e2pUs4iuy115O1DVHmyq8350K1+oVvSzBIYZg4aZwM1AlBvcSTEiFJyz66GfZiniUesjzUhzLpNuZIiJBGeO5O+nFV2EexqoeRnNdFmksbfj/tuYHrykenzCI0UCRBA+KwQluAowYsLCeeqZuAx+10CDnk5xLKGx803BTlwfYnv3hJM5J9QWOuoS7alDH7UXieDNlW0nvYVlVGr9LTqCtco4i9CPgd5RAWMyhWO21OdF4pNK SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2016 12:24:47.1370 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.21];Helo=[milsmgep15.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0201MB1934 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 358 Lines: 13 On 04/16/2016 01:55 PM, Davidlohr Bueso wrote: > ... as the call obviously already implies unlock/RC semantics, > therefore lets get rid of the superfluous smp_mb calls. Hello Davidlohr, Are you sure that this patch has been sent to the right person? I have helped to review a change in this code but I'm not the maintainer of this code. Thanks, Bart.