Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754347AbcDSM5S (ORCPT ); Tue, 19 Apr 2016 08:57:18 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:3658 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753490AbcDSM5Q (ORCPT ); Tue, 19 Apr 2016 08:57:16 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Tue, 19 Apr 2016 05:55:16 -0700 Message-ID: <57162877.3010508@nvidia.com> Date: Tue, 19 Apr 2016 18:15:43 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Thierry Reding CC: , , , , , Subject: Re: [PATCH V2 3/3] gpio: tegra: Add support for gpio debounce References: <1461059020-25373-1-git-send-email-ldewangan@nvidia.com> <1461059020-25373-3-git-send-email-ldewangan@nvidia.com> <20160419123754.GE8284@ulmo.ba.sec> In-Reply-To: <20160419123754.GE8284@ulmo.ba.sec> X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: BGMAIL104.nvidia.com (10.25.59.13) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1033 Lines: 29 On Tuesday 19 April 2016 06:07 PM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Tue, Apr 19, 2016 at 03:13:40PM +0530, Laxman Dewangan wrote: > [...] >> @@ -570,7 +612,14 @@ static struct tegra_gpio_soc_config tegra30_gpio_config = { >> .upper_offset = 0x80, >> }; >> >> +static struct tegra_gpio_soc_config tegra210_gpio_config = { >> + .bank_stride = 0x100, >> + .upper_offset = 0x80, >> + .debounce_supported = true, >> +}; >> + >> static const struct of_device_id tegra_gpio_of_match[] = { >> + { .compatible = "nvidia,tegra210-gpio", .data = &tegra210_gpio_config }, >> { .compatible = "nvidia,tegra30-gpio", .data = &tegra30_gpio_config }, >> { .compatible = "nvidia,tegra20-gpio", .data = &tegra20_gpio_config }, >> { }, > I think I'd split this hunk off into a separate patch. Oh, and perhaps > follow up with a patch that makes the SoC configuration data const? > OK, then I will do that on follow-on patch: - Get rid of all global variables. - Convert the soc config to the constant.