Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754512AbcDSNXN (ORCPT ); Tue, 19 Apr 2016 09:23:13 -0400 Received: from mail-pa0-f67.google.com ([209.85.220.67]:33096 "EHLO mail-pa0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754220AbcDSNXK (ORCPT ); Tue, 19 Apr 2016 09:23:10 -0400 Date: Tue, 19 Apr 2016 21:39:14 +0800 From: Peng Fan To: Fabio Estevam Cc: Shawn Guo , Srinivas Kandagatla , Maxime Ripard , "devicetree@vger.kernel.org" , linux-kernel , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 3/3] nvmem: imx-ocotp: handling clock Message-ID: <20160419133911.GA6823@linux-vaa1.ap.freescale.net> References: <1461054788-339-1-git-send-email-van.freenix@gmail.com> <1461054788-339-3-git-send-email-van.freenix@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 581 Lines: 21 Hi Fabio, On Tue, Apr 19, 2016 at 07:42:17AM -0300, Fabio Estevam wrote: >Hi Peng, > >On Tue, Apr 19, 2016 at 5:33 AM, Peng Fan wrote: > >> @@ -46,11 +48,15 @@ static int imx_ocotp_read(void *context, const void *reg, size_t reg_size, >> if (count > (priv->nregs - index)) >> count = priv->nregs - index; >> >> + clk_prepare_enable(priv->clk); > >clk_prepare_enable() may fail, so you should better check its return >value and propagate it in the case of error. Thanks for correcting me. Will fix it in V2. Thanks, Peng --