Date: Tue, 19 Apr 2016 14:46:17 +0100
From: Will Deacon <will.deacon@arm.com>
To: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Arnd Bergmann <arnd@arndb.de>, Steve Capper <steve.capper@arm.com>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        David Daney <david.daney@cavium.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Leif Lindholm <leif.lindholm@linaro.org>,
        Dan Williams <dan.j.williams@intel.com>, linux-efi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] efi: ARM: avoid warning about phys_addr_t cast
Message-ID: <20160419134616.GD21110@arm.com>
References: <1460968481-169298-1-git-send-email-arnd@arndb.de>
 <20160418211233.GZ2829@codeblueprint.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160418211233.GZ2829@codeblueprint.co.uk>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1035
Lines: 27

On Mon, Apr 18, 2016 at 10:12:33PM +0100, Matt Fleming wrote:
> On Mon, 18 Apr, at 10:34:19AM, Arnd Bergmann wrote:
> > memblock_remove() takes a phys_addr_t, which may be narrower than 64 bits,
> > causing a harmless warning:
> > 
> > drivers/firmware/efi/arm-init.c: In function 'reserve_regions':
> > include/linux/kernel.h:29:20: error: large integer implicitly truncated to unsigned type [-Werror=overflow]
> >  #define ULLONG_MAX (~0ULL)
> >                     ^
> > drivers/firmware/efi/arm-init.c:152:21: note: in expansion of macro 'ULLONG_MAX'
> >   memblock_remove(0, ULLONG_MAX);
> > 
> > This adds an explicit typecast to avoid the warning
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: 500899c2cc3e ("efi: ARM/arm64: ignore DT memory nodes instead of removing them")
> > ---
> >  drivers/firmware/efi/arm-init.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Will, this one is for you.
> 
> Reviewed-by: Matt Fleming <matt@codeblueprint.co.uk>

Thanks, I'll throw it on the pile.

Will