Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754788AbcDSOh7 (ORCPT ); Tue, 19 Apr 2016 10:37:59 -0400 Received: from down.free-electrons.com ([37.187.137.238]:53235 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932143AbcDSOh5 (ORCPT ); Tue, 19 Apr 2016 10:37:57 -0400 Date: Tue, 19 Apr 2016 16:37:54 +0200 From: Alexandre Belloni To: Ludovic Desroches Cc: linus.walleij@linaro.org, nicolas.ferre@atmel.com, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pinctrl: at91-pio4: fix pull-up/down logic Message-ID: <20160419143754.GB29844@piout.net> References: <1461074628-20224-1-git-send-email-ludovic.desroches@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461074628-20224-1-git-send-email-ludovic.desroches@atmel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1548 Lines: 43 On 19/04/2016 at 16:03:45 +0200, Ludovic Desroches wrote : > The default configuration of a pin is often with a value in the > pull-up/down field at chip reset. So, even if the internal logic of the > controller prevents writing a configuration with pull-up and pull-down at > the same time, we must ensure explicitly this condition before writing the > register. > > This was leading to a pull-down condition not taken into account for > instance. > > Signed-off-by: Ludovic Desroches > Fixes: 776180848b57 ("pinctrl: introduce driver for Atmel PIO4 controller") > Cc: stable@vger.kernel.org #v4.4 and later Acked-by: Alexandre Belloni > --- > drivers/pinctrl/pinctrl-at91-pio4.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-at91-pio4.c > index 629b6fe..75093d7 100644 > --- a/drivers/pinctrl/pinctrl-at91-pio4.c > +++ b/drivers/pinctrl/pinctrl-at91-pio4.c > @@ -722,9 +722,11 @@ static int atmel_conf_pin_config_group_set(struct pinctrl_dev *pctldev, > break; > case PIN_CONFIG_BIAS_PULL_UP: > conf |= ATMEL_PIO_PUEN_MASK; > + conf &= (~ATMEL_PIO_PDEN_MASK); > break; > case PIN_CONFIG_BIAS_PULL_DOWN: > conf |= ATMEL_PIO_PDEN_MASK; > + conf &= (~ATMEL_PIO_PUEN_MASK); > break; > case PIN_CONFIG_DRIVE_OPEN_DRAIN: > if (arg == 0) > -- > 2.5.0 > -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com