Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932692AbcDSPnE (ORCPT ); Tue, 19 Apr 2016 11:43:04 -0400 Received: from mail-ig0-f196.google.com ([209.85.213.196]:36088 "EHLO mail-ig0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932575AbcDSPnD (ORCPT ); Tue, 19 Apr 2016 11:43:03 -0400 MIME-Version: 1.0 In-Reply-To: References: <1460832906-24064-2-git-send-email-vishnupatekar0510@gmail.com> <201604170901.pPL2YWTP%fengguang.wu@intel.com> <20160419102234.GD8836@intel.com> From: Vishnu Patekar Date: Tue, 19 Apr 2016 23:42:41 +0800 Message-ID: Subject: Re: [PATCH 1/2] clk: sunxi: add predivider handling for factors clock To: Chen-Yu Tsai Cc: Philip Li , xiaolong.ye@intel.com, kbuild test robot , Stephen Boyd , linux-arm-kernel , Maxime Ripard , linux-sunxi , kbuild-all@01.org, Emilio Lopez , linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3689 Lines: 87 Hello Wens, On Tue, Apr 19, 2016 at 10:16 PM, Chen-Yu Tsai wrote: > On Tue, Apr 19, 2016 at 6:22 PM, Philip Li wrote: >> On Sun, Apr 17, 2016 at 11:53:47AM +0800, Vishnu Patekar wrote: >>> Both of these patches in series has to be applied at the same time. >>> I think this is the reason, it fails. > > You should probably squash the second patch into the first. Yes, I should have, I'll send v2 by combining both patches into one. > > ChenYu > >> hi Xiaolong, would you help do a check whether we apply the patches in correct sequence for this case? >> >> >>> On 17 Apr 2016 09:26, "kbuild test robot" wrote: >>> >>> > Hi Vishnu, >>> > >>> > [auto build test ERROR on clk/clk-next] >>> > [also build test ERROR on v4.6-rc3 next-20160415] >>> > [if your patch is applied to the wrong git tree, please drop us a note to >>> > help improving the system] >>> > >>> > url: >>> > https://github.com/0day-ci/linux/commits/Vishnu-Patekar/sunxi-factors-clock-predivider-handling/20160417-025801 >>> > base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git >>> > clk-next >>> > config: arm-sunxi_defconfig (attached as .config) >>> > reproduce: >>> > wget >>> > https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross >>> > -O ~/bin/make.cross >>> > chmod +x ~/bin/make.cross >>> > # save the attached .config to linux build tree >>> > make.cross ARCH=arm >>> > >>> > Note: the >>> > linux-review/Vishnu-Patekar/sunxi-factors-clock-predivider-handling/20160417-025801 >>> > HEAD 19bb5fc952754381d9f4f9b2e57a1fa09f467359 builds fine. >>> > It only hurts bisectibility. >>> > >>> > All errors (new ones prefixed by >>): >>> > >>> > drivers/clk/sunxi/clk-sunxi.c: In function 'sun6i_get_ahb1_factors': >>> > >> drivers/clk/sunxi/clk-sunxi.c:310:9: error: 'struct factors_request' >>> > has no member named 'parent_index' >>> > if (req->parent_index == SUN6I_AHB1_PARENT_PLL6) { >>> > ^ >>> > drivers/clk/sunxi/clk-sunxi.c: In function 'sun6i_ahb1_recalc': >>> > drivers/clk/sunxi/clk-sunxi.c:340:9: error: 'struct factors_request' >>> > has no member named 'parent_index' >>> > if (req->parent_index == SUN6I_AHB1_PARENT_PLL6) >>> > ^ >>> > >>> > vim +310 drivers/clk/sunxi/clk-sunxi.c >>> > >>> > a78bb355 Chen-Yu Tsai 2016-01-25 304 if (req->parent_rate && req->rate >>> > > req->parent_rate) >>> > a78bb355 Chen-Yu Tsai 2016-01-25 305 req->rate = >>> > req->parent_rate; >>> > a78bb355 Chen-Yu Tsai 2016-01-25 306 >>> > a78bb355 Chen-Yu Tsai 2016-01-25 307 div = >>> > DIV_ROUND_UP(req->parent_rate, req->rate); >>> > a78bb355 Chen-Yu Tsai 2016-01-25 308 >>> > a78bb355 Chen-Yu Tsai 2016-01-25 309 /* calculate pre-divider if parent >>> > is pll6 */ >>> > a78bb355 Chen-Yu Tsai 2016-01-25 @310 if (req->parent_index == >>> > SUN6I_AHB1_PARENT_PLL6) { >>> > a78bb355 Chen-Yu Tsai 2016-01-25 311 if (div < 4) >>> > a78bb355 Chen-Yu Tsai 2016-01-25 312 calcp = 0; >>> > a78bb355 Chen-Yu Tsai 2016-01-25 313 else if (div / 2 < 4) >>> > >>> > :::::: The code at line 310 was first introduced by commit >>> > :::::: a78bb35552a800949b2bf68f372d3d6ccabdd790 clk: sunxi: rewrite >>> > sun6i-a31-ahb1-clk using factors clk with custom recalc >>> > >>> > :::::: TO: Chen-Yu Tsai >>> > :::::: CC: Maxime Ripard >>> > >>> > --- >>> > 0-DAY kernel test infrastructure Open Source Technology >>> > Center >>> > https://lists.01.org/pipermail/kbuild-all Intel >>> > Corporation >>> >