Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933236AbcDSQEv (ORCPT ); Tue, 19 Apr 2016 12:04:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60085 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932571AbcDSQEt (ORCPT ); Tue, 19 Apr 2016 12:04:49 -0400 Date: Tue, 19 Apr 2016 19:04:43 +0300 From: "Michael S. Tsirkin" To: Andy Lutomirski Cc: Cornelia Huck , Christian Borntraeger , "qemu-devel@nongnu.org Developers" , David Woodhouse , Wei Liu , Alex Williamson , peterx@redhat.com, Stefan Hajnoczi , Linux Virtualization , qemu-block@nongnu.org, Kevin Wolf , Amit Shah , "linux-kernel@vger.kernel.org" , Jason Wang , Paolo Bonzini , kvm list Subject: Re: [PATCH RFC] fixup! virtio: convert to use DMA api Message-ID: <20160419190314-mutt-send-email-mst@redhat.com> References: <20160418160731-mutt-send-email-mst@redhat.com> <1460988232.22654.7.camel@infradead.org> <20160418170534-mutt-send-email-mst@redhat.com> <1460992923.3765.8.camel@infradead.org> <20160418182320-mutt-send-email-mst@redhat.com> <1460994701.3765.23.camel@infradead.org> <20160418190203-mutt-send-email-mst@redhat.com> <1461004173.3765.73.camel@infradead.org> <20160419103815-mutt-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 19 Apr 2016 16:04:49 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 613 Lines: 17 On Tue, Apr 19, 2016 at 09:00:27AM -0700, Andy Lutomirski wrote: > On Apr 19, 2016 2:13 AM, "Michael S. Tsirkin" wrote: > > > > > > I guess you are right in that we should split this part out. > > What I wanted is really the combination > > PASSTHROUGH && !PLATFORM so that we can say "ok we don't > > need to guess, this device actually bypasses the IOMMU". > > What happens when you use a device like this on Xen or with a similar > software translation layer? I think you don't use it on Xen since virtio doesn't bypass an IOMMU there. If you do you have misconfigured your device. -- MST