Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933526AbcDSQV3 (ORCPT ); Tue, 19 Apr 2016 12:21:29 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:36852 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933436AbcDSQVZ (ORCPT ); Tue, 19 Apr 2016 12:21:25 -0400 Subject: Re: [PATCH v5 6/6] ARM: dts: DRA7: Add dt nodes for PWMSS To: Tony Lindgren References: <1457400224-24797-1-git-send-email-fcooper@ti.com> <1457400224-24797-7-git-send-email-fcooper@ti.com> <20160317151147.GA29802@rob-hp-laptop> <56EAD315.1030307@ti.com> <20160411202112.GE5995@atomide.com> CC: Rob Herring , , , , , , , , , , , , , , From: "Franklin S Cooper Jr." Message-ID: <57165AD0.7080908@ti.com> Date: Tue, 19 Apr 2016 11:20:32 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160411202112.GE5995@atomide.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1894 Lines: 58 On 04/11/2016 03:21 PM, Tony Lindgren wrote: > * Franklin S Cooper Jr. [160317 08:55]: >> >> >> On 03/17/2016 10:11 AM, Rob Herring wrote: >>> On Mon, Mar 07, 2016 at 07:23:44PM -0600, Franklin S Cooper Jr wrote: >>>> From: Vignesh R >>>> >>>> Add PWMSS device tree nodes for DRA7 SoC family and add documentation >>>> for dt bindings. >>>> >>>> Signed-off-by: Vignesh R >>>> [fcooper@ti.com: Add eCAP and use updated bindings for PWMSS and ePWM] >>>> Signed-off-by: Franklin S Cooper Jr >>>> --- >>>> Version 5 changes: >>>> Add DT node for eCAP and update eCAP binding documentation >>>> >>>> Version 4 changes: >>>> Updated link to the latest documentation >>>> >>>> .../devicetree/bindings/pwm/pwm-tiecap.txt | 9 +++ >>>> .../devicetree/bindings/pwm/pwm-tiehrpwm.txt | 9 +++ >>>> .../devicetree/bindings/pwm/pwm-tipwmss.txt | 15 +++- >>>> arch/arm/boot/dts/dra7.dtsi | 84 ++++++++++++++++++++++ >>>> 4 files changed, 116 insertions(+), 1 deletion(-) >>> >>>> + ehrpwm1: pwm@48440200 { >>>> + compatible = "ti,dra7xx-ehrpwm", >>>> + "ti,am33xx-ehrpwm"; >>>> + #pwm-cells = <3>; >>>> + reg = <0x48440200 0x80>; >>>> + clocks = <&ehrpwm1_tbclk>; >>>> + clock-names = "tbclk"; >>>> + status = "disabled"; >>>> + }; >>>> + >>>> + ecap1: ecap@48440100 { >>> This also is a PWM? Then it should also be pwm@... >> >> The enhanced capture module primary purpose is to measure >> time between external signals which is called capture mode. >> It also has a PWM mode. So I wouldn't recommend generalizing >> the entire node to pwm. > > So is this patch safe for me to apply now or do we need more > changes? No. This patch will change based on changes I will make to handle patch 1 comments. I will send a new rev. > > Regards, > > Tony >