Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754290AbcDSRCI (ORCPT ); Tue, 19 Apr 2016 13:02:08 -0400 Received: from terminus.zytor.com ([198.137.202.10]:39208 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754219AbcDSRCG (ORCPT ); Tue, 19 Apr 2016 13:02:06 -0400 User-Agent: K-9 Mail for Android In-Reply-To: <20160419113501.GA10638@cz.tnic> References: <1460987025-30360-1-git-send-email-dsafonov@virtuozzo.com> <20160419111530.GA1619@gmail.com> <20160419113501.GA10638@cz.tnic> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Subject: Re: [tip:x86/asm] x86/entry: Rename is_{ia32,x32}_task() to in_{ia32,x32}_syscall() From: "H. Peter Anvin" Date: Tue, 19 Apr 2016 10:00:38 -0700 To: Borislav Petkov , Ingo Molnar CC: peterz@infradead.org, dsafonov@virtuozzo.com, luto@kernel.org, dvlasenk@redhat.com, luto@amacapital.net, torvalds@linux-foundation.org, brgerst@gmail.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, linux-tip-commits@vger.kernel.org Message-ID: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 994 Lines: 24 On April 19, 2016 4:35:01 AM PDT, Borislav Petkov wrote: >On Tue, Apr 19, 2016 at 01:15:30PM +0200, Ingo Molnar wrote: >> So I'd suggest the following renames to harmonize these concepts: >> >> - CONFIG_IA32_EMULATION => CONFIG_X86_32_ABI >> this lines up nicely with: CONFIG_X86_X32_ABI > >Except that the only difference now is the "X" in the strings. So one >would need more coffee when staring at those. :) > >> >> - is_ia32_syscall() -> is_x86_32_syscall() >> - is_x32_syscall() -> is_x86_x32_syscall() >> >> - is_compat_syscall() remains as-is. >> >> ... thoughts? > >Still, getting those names streamlined and logical is a step in the >right direction IMO. Let's use the i386 name instead of x86-32; that's what we use elsewhere in the kernel and is much easier to tell apart. Also, less likely to be caught up in "is this i386 only or *any* 32-bit call, including x32"? -- Sent from my Android device with K-9 Mail. Please excuse brevity and formatting.