Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932745AbcDSRq2 (ORCPT ); Tue, 19 Apr 2016 13:46:28 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:35368 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753078AbcDSRq0 (ORCPT ); Tue, 19 Apr 2016 13:46:26 -0400 Subject: Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs To: "David Rivshin (Allworx)" , Grygorii Strashko , "David S. Miller" References: <1461074186-25535-1-git-send-email-andrew.goodbody@cambrionix.com> <1461074186-25535-2-git-send-email-andrew.goodbody@cambrionix.com> <57164383.6080103@ti.com> <20160419110140.75e35c3c.drivshin.allworx@gmail.com> <57165269.40207@ti.com> <20160419131443.7a3b3ef7.drivshin.allworx@gmail.com> Cc: Andrew Goodbody , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, mugunthanvnm@ti.com, tony@atomide.com, andrew@lunn.ch From: Florian Fainelli Message-ID: <57166E6F.90905@gmail.com> Date: Tue, 19 Apr 2016 10:44:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160419131443.7a3b3ef7.drivshin.allworx@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 926 Lines: 19 On 19/04/16 10:14, David Rivshin (Allworx) wrote: >> Ah Ok. There are no user of cpsw_platform_data outside of net/ethernet/ti/, >> so yes, looks like your patch 1 does exactly what's needed. > > Given that the v1 of Andrew's patch is already in Dave's net tree, and > would obviously have many conflicts with mine, how should I proceed? > Since you already requested Dave revert that patch, should I just wait > for that to happen and then resubmit my series? > > Dave, Does that sound good to you? At some point, it would be good for the cpsw driver to be moved to the DSA subsystem, a lot of these tiny little details, like how to attach the PHY to the internal, external, fixed MDIO bus have been solved already using standard DT bindings. This leaves you with the fun part: how to program your switch such that it works in response to the networking stack sollicitations (bridge, VLAN, ethtool etc.). -- Florian