Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933314AbcDSRt4 (ORCPT ); Tue, 19 Apr 2016 13:49:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59187 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752857AbcDSRtz (ORCPT ); Tue, 19 Apr 2016 13:49:55 -0400 Date: Tue, 19 Apr 2016 20:49:48 +0300 From: "Michael S. Tsirkin" To: David Woodhouse Cc: Andy Lutomirski , "qemu-devel@nongnu.org Developers" , "linux-kernel@vger.kernel.org" , Paolo Bonzini , peterx@redhat.com, Cornelia Huck , Stefan Hajnoczi , Kevin Wolf , Amit Shah , qemu-block@nongnu.org, Jason Wang , Alex Williamson , Andy Lutomirski , Christian Borntraeger , Wei Liu , Linux Virtualization , kvm list Subject: Re: [PATCH RFC] fixup! virtio: convert to use DMA api Message-ID: <20160419204907-mutt-send-email-mst@redhat.com> References: <1460994701.3765.23.camel@infradead.org> <20160418190203-mutt-send-email-mst@redhat.com> <1461004173.3765.73.camel@infradead.org> <20160419130732-mutt-send-email-mst@redhat.com> <20160419190520-mutt-send-email-mst@redhat.com> <20160419191914-mutt-send-email-mst@redhat.com> <1461083204.20056.8.camel@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1461083204.20056.8.camel@infradead.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 738 Lines: 19 On Tue, Apr 19, 2016 at 12:26:44PM -0400, David Woodhouse wrote: > On Tue, 2016-04-19 at 19:20 +0300, Michael S. Tsirkin wrote: > > > > > I thought that PLATFORM served that purpose.? Woudn't the host > > > advertise PLATFORM support and, if the guest doesn't ack it, the host > > > device would skip translation?? Or is that problematic for vfio? > > > > Exactly that's problematic for security. > > You can't allow guest driver to decide whether device skips security. > > Right. Because fundamentally, this *isn't* a property of the endpoint > device, and doesn't live in virtio itself. > > It's a property of the platform IOMMU, and lives there. It's a property of the hypervisor virtio implementation, and lives there. -- MST