Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933946AbcDSTKa (ORCPT ); Tue, 19 Apr 2016 15:10:30 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:46261 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932687AbcDSTK1 (ORCPT ); Tue, 19 Apr 2016 15:10:27 -0400 Subject: Re: [PATCH v2 05/13] ARM: dts: db600c: add pmic regulator supplies To: Srinivas Kandagatla , Andy Gross , linux-arm-msm@vger.kernel.org References: <1460453642-5809-1-git-send-email-srinivas.kandagatla@linaro.org> <1460453642-5809-6-git-send-email-srinivas.kandagatla@linaro.org> Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-soc@vger.kernel.org From: Stephen Boyd Message-ID: <571682A1.9010000@codeaurora.org> Date: Tue, 19 Apr 2016 12:10:25 -0700 User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1460453642-5809-6-git-send-email-srinivas.kandagatla@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1379 Lines: 38 On 04/12/2016 02:33 AM, Srinivas Kandagatla wrote: > This patch adds pmic regulator supplies connected on the board. > Rest of the invidual regulators would be added as and when required by > the devices. > > Signed-off-by: Srinivas Kandagatla > Acked-by: Bjorn Andersson > --- > arch/arm/boot/dts/qcom-apq8064-arrow-db600c.dts | 62 +++++++++++++++++++++++++ > 1 file changed, 62 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-apq8064-arrow-db600c.dts b/arch/arm/boot/dts/qcom-apq8064-arrow-db600c.dts > index 57d4500..6695b00 100644 > --- a/arch/arm/boot/dts/qcom-apq8064-arrow-db600c.dts > +++ b/arch/arm/boot/dts/qcom-apq8064-arrow-db600c.dts > @@ -9,7 +9,69 @@ > serial1 = &gsbi1_serial; > }; > > + regulators { > + compatible = "simple-bus"; > + vph: regulator-fixed@1 { > + compatible = "regulator-fixed"; > + regulator-min-microvolt = <4500000>; > + regulator-max-microvolt = <4500000>; > + regulator-name = "VPH"; > + regulator-type = "voltage"; > + regulator-boot-on; > + }; > + }; Just curious why we added the vph supply? Is that for some framework requirement? We haven't done this on other boards, although we probably should if there's a good reason for it. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project