Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752665AbcDSWN6 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 19 Apr 2016 18:13:58 -0400
Received: from mail.kernel.org ([198.145.29.136]:42619 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750717AbcDSWNz (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 19 Apr 2016 18:13:55 -0400
Date: Tue, 19 Apr 2016 17:13:49 -0500
From: Rob Herring <robh@kernel.org>
To: Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>
Cc: linux-input@vger.kernel.org, Heiko Stuebner <heiko@sntech.de>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Julien Chauveau <chauveau.julien@gmail.com>,
        Javier Martinez Canillas <javier@dowhile0.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>
Subject: Re: [PATCH v2] Documentation: devicetree: Clean up gpio-keys example
Message-ID: <20160419221349.GA25916@rob-hp-laptop>
References: <1458129209-15449-1-git-send-email-afaerber@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1458129209-15449-1-git-send-email-afaerber@suse.de>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1683
Lines: 57

On Wed, Mar 16, 2016 at 12:53:29PM +0100, Andreas F?rber wrote:
> Drop #address-cells and #size-cells, which are not required by the
> gpio-keys binding documentation, as button sub-nodes are not devices.
> 
> Rename sub-nodes to avoid new dtc unit address warnings when copied.
> 
> While at it, adopt the dashes convention for the node name.
> 
> Reported-by: Julien Chauveau <chauveau.julien@gmail.com>
> Cc: Julien Chauveau <chauveau.julien@gmail.com>
> Cc: Javier Martinez Canillas <javier@dowhile0.org>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Andreas F?rber <afaerber@suse.de>

Applied, thanks.

Rob

> ---
>  v1 -> v2:
>  * Changed node name from underscore to dash
>  * Inserted white lines
>  * Renamed sub-nodes (Geert, Julien)
>  
>  Documentation/devicetree/bindings/input/gpio-keys.txt | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/input/gpio-keys.txt b/Documentation/devicetree/bindings/input/gpio-keys.txt
> index 21641236c095..a94940481e55 100644
> --- a/Documentation/devicetree/bindings/input/gpio-keys.txt
> +++ b/Documentation/devicetree/bindings/input/gpio-keys.txt
> @@ -32,17 +32,17 @@ Optional subnode-properties:
>  
>  Example nodes:
>  
> -	gpio_keys {
> +	gpio-keys {
>  			compatible = "gpio-keys";
> -			#address-cells = <1>;
> -			#size-cells = <0>;
>  			autorepeat;
> -			button@21 {
> +
> +			up {
>  				label = "GPIO Key UP";
>  				linux,code = <103>;
>  				gpios = <&gpio1 0 1>;
>  			};
> -			button@22 {
> +
> +			down {
>  				label = "GPIO Key DOWN";
>  				linux,code = <108>;
>  				interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
> -- 
> 2.6.2
>