From: Stuart Yoder <stuart.yoder@nxp.com>
To: Shawn Guo <shawnguo@kernel.org>
CC: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        "german.rivera@freescale.com" <german.rivera@freescale.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        Yang-Leo Li <leoyang.li@nxp.com>
Subject: RE: [PATCH 2/2 v2] arm64: dts: ls2080a: fsl-mc dt node updates
Thread-Topic: [PATCH 2/2 v2] arm64: dts: ls2080a: fsl-mc dt node updates
Thread-Index: AQHRlcg4Tba0T60Z20+tWQTWsco3N5+PEDEAgALOWxA=
Date: Tue, 19 Apr 2016 21:51:51 +0000
Message-ID: <HE1PR04MB1641C5D0299D1125A62284048D6C0@HE1PR04MB1641.eurprd04.prod.outlook.com>
References: <1460581523-32146-1-git-send-email-stuart.yoder@nxp.com>
 <20160418025618.GU28903@tiger>
In-Reply-To: <20160418025618.GU28903@tiger>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:23
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2016 21:51:51.8847
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR04MB0781
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 3336
Lines: 109


> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo@kernel.org]
> Sent: Sunday, April 17, 2016 9:56 PM
> To: Stuart Yoder <stuart.yoder@nxp.com>
> Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; german.rivera@freescale.com;
> linux-kernel@vger.kernel.org; robh+dt@kernel.org; Yang-Leo Li <leoyang.li@nxp.com>
> Subject: Re: [PATCH 2/2 v2] arm64: dts: ls2080a: fsl-mc dt node updates
> 
> On Wed, Apr 13, 2016 at 04:05:23PM -0500, Stuart Yoder wrote:
> > updates to the fsl-mc node for full functionality:
> >    -msi-parent is needed for interrupt support
> >    -ranges is needed to enable the bus driver to translate bus addresses
> >    -dpmac nodes provide a basis for relating dpmac objects to PHYs
> >
> > Signed-off-by: Stuart Yoder <stuart.yoder@nxp.com>
> > ---
> >
> > -v2: updated comment to remove some extraneous info, added
> >      carriage returns after dpmac nodes
> >
> >  arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi | 98 ++++++++++++++++++++++++++
> >  1 file changed, 98 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi b/arch/arm64/boot/dts/freescale/fsl-
> ls2080a.dtsi
> > index 9d746c6..15498eb 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
> > @@ -265,6 +265,104 @@
> >  			compatible = "fsl,qoriq-mc";
> >  			reg = <0x00000008 0x0c000000 0 0x40>,	 /* MC portal base */
> >  			      <0x00000000 0x08340000 0 0x40000>; /* MC control reg */
> > +			msi-parent = <&its>;
> > +			#address-cells = <3>;
> > +			#size-cells = <1>;
> > +
> > +			/*
> > +			 * Region type 0x0 - MC portals
> > +			 * Region type 0x1 - QBMAN portals
> > +			 */
> > +			ranges = <0x0 0x0 0x0 0x8 0x0c000000 0x4000000
> > +				  0x1 0x0 0x0 0x8 0x18000000 0x8000000>;
> > +
> > +			/*
> > +			 * Define the maximum number of MACs present on the SoC.
> > +			 */
> > +			dpmacs {
> > +				#address-cells = <1>;
> > +				#size-cells = <0>;
> > +
> > +				dpmac1: dpmac@1 {
> > +					compatible = "fsl,qoriq-mc-dpmac";
> > +					reg = <1>;
> > +				};
> > +
> > +				dpmac2: dpmac@2 {
> > +					compatible = "fsl,qoriq-mc-dpmac";
> > +					reg = <2>;
> > +				};
> > +
> > +				dpmac3: dpmac@3 {
> > +					compatible = "fsl,qoriq-mc-dpmac";
> > +					reg = <3>;
> > +				};
> > +
> > +				dpmac4: dpmac@4 {
> > +					compatible = "fsl,qoriq-mc-dpmac";
> > +					reg = <4>;
> > +				};
> > +
> > +				dpmac5: dpmac@5 {
> > +					compatible = "fsl,qoriq-mc-dpmac";
> > +					reg = <5>;
> > +				};
> > +
> > +				dpmac6: dpmac@6 {
> > +					compatible = "fsl,qoriq-mc-dpmac";
> > +					reg = <6>;
> > +				};
> > +
> > +				dpmac7: dpmac@7 {
> > +					compatible = "fsl,qoriq-mc-dpmac";
> > +					reg = <7>;
> > +				};
> > +
> > +				dpmac8: dpmac@8 {
> > +					compatible = "fsl,qoriq-mc-dpmac";
> > +					reg = <8>;
> > +				};
> > +
> > +				dpmac9: dpmac@9 {
> > +					compatible = "fsl,qoriq-mc-dpmac";
> > +					reg = <9>;
> > +				};
> > +
> > +				dpmac10: dpmac@10 {
> 
> The unit-address should be same as reg property, i.e. both are in hex
> value.

Ok, will update.  I am going to leave the labels in decimal because
that is how we refer to these mac devices in normal usage and in our
documentation.  ls2080a users expect dpmac10 to be the 10th mac not
the 16th.

Thanks,
Stuart