Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754167AbcDTAso (ORCPT ); Tue, 19 Apr 2016 20:48:44 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:32973 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751878AbcDTAsm (ORCPT ); Tue, 19 Apr 2016 20:48:42 -0400 MIME-Version: 1.0 In-Reply-To: <6087716.bi8vDPiZNy@vostro.rjw.lan> References: <1460958684-32105-1-git-send-email-wanpeng.li@hotmail.com> <6087716.bi8vDPiZNy@vostro.rjw.lan> Date: Wed, 20 Apr 2016 08:48:41 +0800 Message-ID: Subject: Re: [PATCH] sched/cpufreq: don't trigger cpufreq update w/o real rt/deadline tasks running From: Wanpeng Li To: "Rafael J. Wysocki" Cc: Peter Zijlstra , Ingo Molnar , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , Wanpeng Li , Linux PM list , Steve Muckle Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 665 Lines: 17 2016-04-20 8:32 GMT+08:00 Rafael J. Wysocki : > On Monday, April 18, 2016 01:51:24 PM Wanpeng Li wrote: >> Sometimes update_curr() is called w/o tasks actually running, it is >> captured by: >> u64 delta_exec = rq_clock_task(rq) - curr->se.exec_start; >> We should not trigger cpufreq update in this case for rt/deadline >> classes, and this patch fix it. >> >> Signed-off-by: Wanpeng Li > > The signed-off-by tag should agree with the From: header. One way to achieve > that is to add an extra From: line at the start of the changelog. Thanks for the tip Rafael, just send out v2 to fix it. Regards, Wanpeng Li