Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932072AbcDTBQi (ORCPT ); Tue, 19 Apr 2016 21:16:38 -0400 Received: from mail-ig0-f171.google.com ([209.85.213.171]:36759 "EHLO mail-ig0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752096AbcDTBQg (ORCPT ); Tue, 19 Apr 2016 21:16:36 -0400 MIME-Version: 1.0 In-Reply-To: <1460969178-20914-2-git-send-email-ldewangan@nvidia.com> References: <1460969178-20914-1-git-send-email-ldewangan@nvidia.com> <1460969178-20914-2-git-send-email-ldewangan@nvidia.com> From: Alexandre Courbot Date: Wed, 20 Apr 2016 10:16:15 +0900 Message-ID: Subject: Re: [PATCH 2/3] gpio: tegra: Remove the need of keeping device handle for gpio driver To: Laxman Dewangan Cc: Linus Walleij , Stephen Warren , Thierry Reding , "linux-gpio@vger.kernel.org" , "linux-tegra@vger.kernel.org" , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 547 Lines: 12 On Mon, Apr 18, 2016 at 5:46 PM, Laxman Dewangan wrote: > Remove the file static device handle variable as this is just > required for prints. The required handle can be stored in > tegra_gpio_chip and hence it become redundancy. Small but still worthy change. "dev" in the file's global namespace is scary and prone to conflict with local variables declarations. Acked-by: Alexandre Courbot Now I hope you will take care of "regs" and the other static variables as Stephen rightfully suggested. :)