Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753908AbcDTGnP (ORCPT ); Wed, 20 Apr 2016 02:43:15 -0400 Received: from nat-hk.nvidia.com ([203.18.50.4]:30282 "EHLO hkmmgate102.nvidia.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751964AbcDTGnN convert rfc822-to-8bit (ORCPT ); Wed, 20 Apr 2016 02:43:13 -0400 X-PGP-Universal: processed; by hkpgpgate102.nvidia.com on Tue, 19 Apr 2016 23:43:09 -0700 Message-ID: <57172546.6090106@nvidia.com> Date: Wed, 20 Apr 2016 14:44:22 +0800 From: Wei Ni User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Thierry Reding CC: Arnd Bergmann , Eduardo Valentin , Zhang Rui , Stephen Warren , Alexandre Courbot , Jon Hunter , , , Subject: Re: [PATCH] thermal: tegra: mark PM functions __maybe_unused References: <1460838026-1242452-1-git-send-email-arnd@arndb.de> <20160418071513.GA13078@ulmo.ba.sec> <5715998B.6080607@nvidia.com> <20160419124319.GG8284@ulmo.ba.sec> In-Reply-To: <20160419124319.GG8284@ulmo.ba.sec> X-Originating-IP: [10.19.224.146] X-ClientProxiedBy: HKMAIL103.nvidia.com (10.18.16.12) To HKMAIL102.nvidia.com (10.18.16.11) Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1874 Lines: 56 On 2016年04月19日 20:43, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Tue, Apr 19, 2016 at 10:35:55AM +0800, Wei Ni wrote: >> >> >> On 2016年04月18日 15:15, Thierry Reding wrote: >>>> Old Signed by an unknown key >>> >>> On Sat, Apr 16, 2016 at 10:19:33PM +0200, Arnd Bergmann wrote: >>>> After the PM support has been added to this driver, we get >>>> a harmless warning when that support is disabled at compile >>>> time: >>>> >>>> drivers/thermal/tegra/soctherm.c:641:12: error: 'soctherm_resume' defined but not used [-Werror=unused-function] >>>> static int soctherm_resume(struct device *dev) >>>> >>>> This marks the two PM functions as __maybe_unused to shut up >>>> the warning. This is preferred over adding an #ifdef around >>>> them, as it is harder to get wrong, and provides better >>>> compile-time coverage. >>>> >>>> Signed-off-by: Arnd Bergmann >>>> Fixes: a134b4143b65 ("thermal: tegra: add PM support") >>>> --- >>>> drivers/thermal/tegra/soctherm.c | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> The need for this should go away when Jon's generic power domain series >> >> Hi Thierry, >> Could you please show me the Jon's generic power domain series, so that I can >> verify it. > > Here are the remaining patches from Jon's series: > > https://patchwork.ozlabs.org/patch/603285/ > https://patchwork.ozlabs.org/patch/603287/ > https://patchwork.ozlabs.org/patch/603284/ I checked this generic power domain series, it select PM and PM_GENERIC_DOMAINS for Tegra SoC Family. But the soctherm_suspend/resume callbacks defined by SIMPLE_DEV_PM_OPS are only used when the CONFIG_PM_SLEEP is enabled, so if the CONFIG_PM_SLEEP is disabled, we still will get this warning. So to avoid the warning, I think this patch is needed. Wei. > > Thierry > > * Unknown Key > * 0x7F3EB3A1 >