Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754524AbcDTH52 (ORCPT ); Wed, 20 Apr 2016 03:57:28 -0400 Received: from mx2.suse.de ([195.135.220.15]:46201 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752626AbcDTH51 (ORCPT ); Wed, 20 Apr 2016 03:57:27 -0400 Date: Wed, 20 Apr 2016 09:57:24 +0200 From: Michal Marek To: Julia Lawall Cc: Wolfram Sang , linux-kernel@vger.kernel.org, Gilles Muller , Nicolas Palix , Michal Marek , cocci@systeme.lip6.fr Subject: Re: [PATCH] scripts: coccinelle: remove check to move constants to right Message-ID: <20160420075723.GA15339@pobox.suse.cz> References: <1458409079-4669-1-git-send-email-wsa@the-dreams.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 686 Lines: 17 On Sat, Mar 19, 2016 at 06:43:08PM +0100, Julia Lawall wrote: > On Sat, 19 Mar 2016, Wolfram Sang wrote: > > > The header mentions this check depends on personal taste. I agree. > > Running coccicheck on patches before I apply them, this SmPL produced > > enough false positives for me that I'd rather see it removed. > > An improvement is coming up, that should be more acceptable. However, > it's being held up by the need for some bug fixes in Coccinelle. A > release of Coccinelle is planned for the beginning of April. Perhaps > it is just as well to just remove this version for now. > > Acked-by: Julia Lawall Applied to kbuild.git#misc. Michal