Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932854AbcDTH7g (ORCPT ); Wed, 20 Apr 2016 03:59:36 -0400 Received: from mail-qk0-f194.google.com ([209.85.220.194]:34357 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754532AbcDTH7d (ORCPT ); Wed, 20 Apr 2016 03:59:33 -0400 MIME-Version: 1.0 In-Reply-To: <1461136800-20334-1-git-send-email-appanad@xilinx.com> References: <1461136800-20334-1-git-send-email-appanad@xilinx.com> Date: Wed, 20 Apr 2016 13:29:32 +0530 Message-ID: Subject: Re: [PATCH 1/2] Documentation: DT: vdma: Add clock support for vdma From: Shubhrajyoti Datta To: Kedareswara rao Appana Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Michal Simek , =?UTF-8?Q?S=C3=B6ren_Brinkmann?= , vinod.koul@intel.com, dan.j.williams@intel.com, appanad@xilinx.com, Moritz Fischer , Laurent Pinchart , luis@debethencourt.com, anirudh@xilinx.com, punnaia@xilinx.com, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2261 Lines: 54 On Wed, Apr 20, 2016 at 12:49 PM, Kedareswara rao Appana wrote: > This patch updates the binding doc with clock description > for vdma. > > Signed-off-by: Kedareswara rao Appana > --- > Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt > index fcc2b65..e1c9019 100644 > --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt > +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt > @@ -21,6 +21,10 @@ Required properties: > - dma-channel child node: Should have at least one channel and can have up to > two channels per device. This node specifies the properties of each > DMA channel (see child node properties below). > +- clocks: Input clock specifier. Refer to common clock bindings. > +- clock-names: List of input clocks "axi_clk", "tx_clk", "txs_clk" (list of input > + cloks may vary based on the ip configuration. see clock bindings > + for more info). > > Required properties for VDMA: > - xlnx,num-fstores: Should be the number of framebuffers as configured in h/w. > @@ -60,6 +64,8 @@ axi_vdma_0: axivdma@40030000 { > xlnx,num-fstores = <0x8>; > xlnx,flush-fsync = <0x1>; > xlnx,addrwidth = <0x20>; > + clocks = <&clk 0>, <&clk 1>, <&clk 2>; > + clock-names = "axi_clk", "tx_clk", "txs_clk"; the module has s_axi_lite_aclk Clock I AXI VDMA AXI4-Lite interface clock m_axi_mm2s_aclk Clock I AXI VDMA MM2S clock m_axi_s2mm_aclk Clock I AXI VDMA S2MM clock m_axis_mm2s_aclk Clock I AXI VDMA MM2S AXIS clock s_axis_s2mm_aclk Clock I AXI VDMA S2MM AXIS clock I think a partial support is not wrong. however we should keep the names same as the TRM. > dma-channel@40030000 { > compatible = "xlnx,axi-vdma-mm2s-channel"; > interrupts = < 0 54 4 >; > -- > 2.1.2 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel