Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933019AbcDTIBH (ORCPT ); Wed, 20 Apr 2016 04:01:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57357 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932632AbcDTH7x (ORCPT ); Wed, 20 Apr 2016 03:59:53 -0400 Date: Wed, 20 Apr 2016 09:59:45 +0200 From: Jiri Olsa To: Wang Nan Cc: acme@kernel.org, linux-kernel@vger.kernel.org, pi3orama@163.com, Adrian Hunter , Jiri Olsa , Masami Hiramatsu , Namhyung Kim , Zefan Li , He Kuang , Arnaldo Carvalho de Melo Subject: Re: [PATCH v5 3/6] perf record: Force enable --timestamp-filename when --switch-output is provided Message-ID: <20160420075945.GA18012@krava.redhat.com> References: <1460991332-185772-1-git-send-email-wangnan0@huawei.com> <1460991332-185772-4-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460991332-185772-4-git-send-email-wangnan0@huawei.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 20 Apr 2016 07:59:52 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1475 Lines: 46 On Mon, Apr 18, 2016 at 02:55:29PM +0000, Wang Nan wrote: > Without this patch, the last output doesn't have timestamp appended if > --timestamp-filename is not explicitly provided. For example: > > # perf record -a --switch-output & > [1] 11224 > # kill -s SIGUSR2 11224 > [ perf record: dump data: Woken up 1 times ] > # [ perf record: Dump perf.data.2015122622372823 ] > > # fg > perf record -a --switch-output > ^C[ perf record: Woken up 1 times to write data ] > [ perf record: Captured and wrote 0.027 MB perf.data (540 samples) ] > > # ls -l > total 836 > -rw------- 1 root root 33256 Dec 26 22:37 perf.data <---- *Odd* > -rw------- 1 root root 817156 Dec 26 22:37 perf.data.2015122622372823 I'm getting this: [root@krava perf]# ./perf record -a --switch-output & [root@krava perf]# kill -s SIGUSR2 18974 [ perf record: dump data: Woken up 4 times ] [ perf record: Dump perf.data.2016042009574314 ] [root@krava perf]# ./perf report -i perf.data.2016042009574314 perf: Segmentation fault -------- backtrace -------- ./perf[0x552b0b] /lib64/libc.so.6(+0x34a50)[0x7f711b434a50] /lib64/libc.so.6(strlen+0x2a)[0x7f711b48b33a] ./perf(perf_hpp__reset_sort_width+0x4f)[0x4e9b1f] ./perf[0x54b113] ./perf(perf_evlist__tui_browse_hists+0x91)[0x551361] ./perf(cmd_report+0x1a34)[0x434b44] ./perf[0x485681] ./perf(main+0x672)[0x424382] /lib64/libc.so.6(__libc_start_main+0xf0)[0x7f711b420700] ./perf(_start+0x29)[0x4244a9] [0x0] thanks, jirka