Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933125AbcDTI6H (ORCPT ); Wed, 20 Apr 2016 04:58:07 -0400 Received: from mx2.suse.de ([195.135.220.15]:49318 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932391AbcDTI6D (ORCPT ); Wed, 20 Apr 2016 04:58:03 -0400 Date: Wed, 20 Apr 2016 10:57:55 +0200 From: Johannes Thumshirn To: Andreas Werner Cc: morbidrsa@gmail.com, linux-kernel@vger.kernel.org, jthumshirn@suse.de Subject: Re: [PATCH] mcb: Fixed bar number assignment for the gdd Message-ID: <20160420085755.GA28402@c203.arch.suse.de> References: <20160420063538.GA2684@awelinux> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160420063538.GA2684@awelinux> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1183 Lines: 36 On Wed, Apr 20, 2016 at 08:35:47AM +0200, Andreas Werner wrote: > The bar number is found in reg2 within the gdd. Therefore > we need to change the assigment from reg1 to reg2 which > is the correct location. > > Signed-off-by: Andreas Werner > --- > drivers/mcb/mcb-parse.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mcb/mcb-parse.c b/drivers/mcb/mcb-parse.c > index 0049269..b0155b0 100644 > --- a/drivers/mcb/mcb-parse.c > +++ b/drivers/mcb/mcb-parse.c > @@ -57,7 +57,7 @@ static int chameleon_parse_gdd(struct mcb_bus *bus, > mdev->id = GDD_DEV(reg1); > mdev->rev = GDD_REV(reg1); > mdev->var = GDD_VAR(reg1); > - mdev->bar = GDD_BAR(reg1); > + mdev->bar = GDD_BAR(reg2); > mdev->group = GDD_GRP(reg2); > mdev->inst = GDD_INS(reg2); > > -- > 2.6.2 > Applied, thanks. -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850