Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754444AbcDTJIZ (ORCPT <rfc822;w@1wt.eu>);
	Wed, 20 Apr 2016 05:08:25 -0400
Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:48368 "EHLO
	metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751184AbcDTJIW (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 20 Apr 2016 05:08:22 -0400
From: Markus Pargmann <mpa@pengutronix.de>
To: Mikulas Patocka <mikulas@twibright.com>
Cc: Oleg Nesterov <oleg@redhat.com>, Christoph Hellwig <hch@lst.de>,
        nbd-general@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: Warning when unloading network block device
Date: Wed, 20 Apr 2016 11:08:09 +0200
Message-ID: <2076938.ix83ekSxsQ@adelgunde>
User-Agent: KMail/4.14.1 (Linux/4.4.0-0.bpo.1-amd64; KDE/4.14.2; x86_64; ; )
In-Reply-To: <alpine.DEB.2.02.1604151823510.23676@leontynka>
References: <alpine.DEB.2.02.1604151823510.23676@leontynka>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart2181347.T4yNGbefHd"; micalg="pgp-sha256"; protocol="application/pgp-signature"
X-SA-Exim-Connect-IP: 2001:67c:670:100:a61f:72ff:fe68:75ba
X-SA-Exim-Mail-From: mpa@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false
X-PTX-Original-Recipient: linux-kernel@vger.kernel.org
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 3489
Lines: 95


--nextPart2181347.T4yNGbefHd
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="us-ascii"

Hi,

On Friday 15 April 2016 18:30:32 Mikulas Patocka wrote:
> Hi
>=20
> The patch 23272a6754b81ff6503e09c743bb4ceeeab39997 (nbd: Remove signa=
l=20
> usage) triggers a warning in nbd when the network block device is unl=
oaded=20
> - WARN_ON_ONCE(in_irq() || irqs_disabled()) in the function=20
> __local_bh_enable_ip. The reason for the warning is that the function=
=20
> kernel_sock_shutdown is called with interrupts disabled.

Thanks for reporting. Will post a patch soon.

Best Regards,

Markus

>=20
> block nbd0: NBD_DISCONNECT
> block nbd0: shutting down socket
> ------------[ cut here ]------------
> WARNING: CPU: 10 PID: 11939 at kernel/softirq.c:150 __local_bh_enable=
_ip+0x66/0x90
> Call Trace:
>  [<ffffffff8122dde3>] ? dump_stack+0x46/0x63
>  [<ffffffff81050f57>] ? __warn+0xe7/0x100
>  [<ffffffff810555f6>] ? __local_bh_enable_ip+0x66/0x90
>  [<ffffffff813e2ddf>] ? inet_shutdown+0x3f/0x120
>  [<ffffffffa00693b0>] ? sock_shutdown+0x40/0x80 [nbd]
>  [<ffffffffa006a228>] ? __nbd_ioctl+0x5b8/0xa40 [nbd]
>  [<ffffffffa19cc169>] ? soft_cursor+0x169/0x1e6 [softcursor]
>  [<ffffffffa19e37ed>] ? bit_cursor+0x59d/0x5d0 [bitblit]
>  [<ffffffffa19e8801>] ? cursor_timer_handler+0x11/0x40 [fbcon]
>  [<ffffffff8108dd6d>] ? up+0xd/0x50
>  [<ffffffff81092ba6>] ? console_unlock+0x216/0x580
>  [<ffffffff8108c168>] ? remove_wait_queue+0x18/0x60
>  [<ffffffff812a6dca>] ? n_tty_write+0x24a/0x460
>  [<ffffffff811f7cec>] ? security_capable+0x3c/0x50
>  [<ffffffffa006a717>] ? nbd_ioctl+0x67/0x99 [nbd]
>  [<ffffffff8121d2d9>] ? blkdev_ioctl+0x649/0xa70
>  [<ffffffff81160c2e>] ? __vfs_write+0x1e/0xe0
>  [<ffffffff811789c2>] ? dput+0x42/0x2b0
>  [<ffffffff81199e14>] ? block_ioctl+0x34/0x40
>  [<ffffffff81174806>] ? do_vfs_ioctl+0x96/0x5b0
>  [<ffffffff81161c31>] ? vfs_write+0x131/0x190
>  [<ffffffff81174db1>] ? SyS_ioctl+0x91/0xa0
>  [<ffffffff81402e1f>] ? entry_SYSCALL_64_fastpath+0x17/0x93
> ---[ end trace 1956420c2e5f102b ]---
> block nbd0: Receive control failed (result -32)
>=20
> Mikulas
>=20

=2D-=20
Pengutronix e.K.                           |                           =
  |
Industrial Linux Solutions                 | http://www.pengutronix.de/=
  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0  =
  |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-555=
5 |

--nextPart2181347.T4yNGbefHd
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJXF0b/AAoJEEpcgKtcEGQQ8GQQALc8TejShSdH12Lk18o5UjuE
sSE46IRN368kwJEQ232FEtd8q6PWJ2DbVPaIVzrDYjT8swq5yXZQIBAvm24CIgM+
0S7nUcoHtLW56hmt6WT6ZLTuttdKqdcY1CTJn6Std+6UVsXmFwksg0bNWd2mKD/D
jAPk+EaYv8KtRQewCiiBYIL11DD5EF4ai3e1dlU9DBRG9I5QpaP4ZK+AqmrEOJmt
P1lAULea9nT/QiP6BDMgwvvBNpjUtT+BNx6GN29BTiwM6KMeQahH35Pb8FDznf1L
rQelX2siqn7G9MLfxORIAjF+Q9QE96xGB+GMx0M/LfHj34xQgiiWHkRmQqJoPHt0
cDl8W8mbywaMrUDVhqTf3Len3cMMGM5NbFR5GqyZtCNGRR+YYx8fvA2zi0LW3xeM
+M7ZBiZYdSfiEcRSezCbQJevwXbnPTl5Pgufq+mFoHlwTz9dowIpFXtSLi9zEQmB
t8ViZOLEnMBlDWcEU4xXSnBndsdm7fUz9PmsGrSVow7QMECqtqbVALLgQtVjhSMr
Kg7zDd5Nk2BH0FsoA8P2QQm5E70jZlvGXtH6G5DwVD5a+v9JN1h3Sz6O18+7xPTo
O7djf7C7faDejyZdvUe8hNmvS4LClmLecX51QUSvdVOGoh7eGb7EjpXDhvuFfi78
Jzl0ks1mCk416L9RT9N7
=coIM
-----END PGP SIGNATURE-----

--nextPart2181347.T4yNGbefHd--