Subject: Re: [PATCH 2/2] crypto: s5p-sss - Remove useless hash interrupt
 handler
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
References: <1461073452-10426-1-git-send-email-k.kozlowski@samsung.com>
 <1461073452-10426-2-git-send-email-k.kozlowski@samsung.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
From: Vladimir Zapolskiy <vz@mleia.com>
Message-ID: <57175412.4070501@mleia.com>
Date: Wed, 20 Apr 2016 13:04:02 +0300
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101
 Icedove/38.5.0
MIME-Version: 1.0
In-Reply-To: <1461073452-10426-2-git-send-email-k.kozlowski@samsung.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 828
Lines: 24

On 19.04.2016 16:44, Krzysztof Kozlowski wrote:
> Beside regular feed control interrupt, the driver requires also hash
> interrupt for older SoCs (samsung,s5pv210-secss). However after
> requesting it, the interrupt handler isn't doing anything with it, not
> even clearing the hash interrupt bit.
> 
> Driver does not provide hash functions so it is safe to remove the hash
> interrupt related code and to not require the interrupt in Device Tree.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Thank you for the change.

Acked-by: Vladimir Zapolskiy <vz@mleia.com>

> ---
>  .../devicetree/bindings/crypto/samsung-sss.txt     |  6 ++--
>  drivers/crypto/s5p-sss.c                           | 34 ++++------------------
>  2 files changed, 8 insertions(+), 32 deletions(-)
> 

---
With best wishes,
Vladimir