Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964925AbcDTL04 (ORCPT ); Wed, 20 Apr 2016 07:26:56 -0400 Received: from dougal.metanate.com ([90.155.101.14]:22091 "EHLO metanate.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932393AbcDTL0w (ORCPT ); Wed, 20 Apr 2016 07:26:52 -0400 Date: Wed, 20 Apr 2016 12:26:32 +0100 From: John Keeping To: Mark Yao Cc: David Airlie , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] drm/rockchip: get rid of rockchip_drm_crtc_mode_config Message-ID: <20160420122632.69378803.john@metanate.com> In-Reply-To: <1461120102-32054-1-git-send-email-mark.yao@rock-chips.com> References: <1461119505-27076-1-git-send-email-mark.yao@rock-chips.com> <1461120102-32054-1-git-send-email-mark.yao@rock-chips.com> Organization: Metanate Ltd X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 423 Lines: 13 On Wed, 20 Apr 2016 10:41:42 +0800, Mark Yao wrote: > We need to take care of the vop status when use > rockchip_drm_crtc_mode_config, if vop is disabled, > the function would failed, that is terrible. > > Save output_type and output_mode into rockchip_crtc_state, > it's nice to make them into atomic. > > Signed-off-by: Mark Yao Tested-by: John Keeping (for HDMI output)