From: Horia Ioan Geanta Neag <horia.geanta@nxp.com>
To: Stuart Yoder <stuart.yoder@nxp.com>, Jose Rivera <german.rivera@nxp.com>
CC: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "agraf@suse.de" <agraf@suse.de>, "arnd@arndb.de" <arnd@arndb.de>,
        Yang-Leo Li <leoyang.li@nxp.com>
Subject: Re: [PATCH 11/14] staging: fsl-mc: add quirk handling for dpseci
 objects < 4.0
Thread-Topic: [PATCH 11/14] staging: fsl-mc: add quirk handling for dpseci
 objects < 4.0
Thread-Index: AQHRmvmYbcYxDupWTUOfc+tVprAkvg==
Date: Wed, 20 Apr 2016 11:41:37 +0000
Message-ID: <AM2PR04MB06737EA9EDC63E34585AA415986D0@AM2PR04MB0673.eurprd04.prod.outlook.com>
References: <1460393426-16118-1-git-send-email-stuart.yoder@nxp.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:23
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2016 11:41:37.7775
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0769
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1425
Lines: 43

On 4/11/2016 7:50 PM, Stuart Yoder wrote:
> From: Horia Geanta <horia.geanta@nxp.com>
> 
> dpseci objects < 4.0 are not coherent-- in spite of the fact
> that the MC reports them to be coherent in certain versions.
> Add a special case to set the no shareability flag for dpseci
> objects < 4.0.
> 
> Signed-off-by: Horia Geanta <horia.geanta@nxp.com>
> (Stuart: reworded commit message, updated comment in patch)
> Signed-off-by: Stuart Yoder <stuart.yoder@nxp.com>

Do we really need this?
First upstream dpsec driver will be for dpsec >= v4.0.

Thanks,
Horia

> ---
>  drivers/staging/fsl-mc/bus/dprc-driver.c |    9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/staging/fsl-mc/bus/dprc-driver.c b/drivers/staging/fsl-mc/bus/dprc-driver.c
> index 53c6e98..7fc4717 100644
> --- a/drivers/staging/fsl-mc/bus/dprc-driver.c
> +++ b/drivers/staging/fsl-mc/bus/dprc-driver.c
> @@ -312,6 +312,15 @@ int dprc_scan_objects(struct fsl_mc_device *mc_bus_dev,
>  				continue;
>  			}
>  
> +			/*
> +			 * add a quirk for all versions of dpsec < 4.0...none
> +			 * are coherent regardless of what the MC reports.
> +			 */
> +			if ((strcmp(obj_desc->type, "dpseci") == 0) &&
> +			    (obj_desc->ver_major < 4))
> +				obj_desc->flags |=
> +					DPRC_OBJ_FLAG_NO_MEM_SHAREABILITY;
> +
>  			irq_count += obj_desc->irq_count;
>  			dev_dbg(&mc_bus_dev->dev,
>  				"Discovered object: type %s, id %d\n",
>