Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754067AbcDTNrQ (ORCPT ); Wed, 20 Apr 2016 09:47:16 -0400 Received: from lists.s-osg.org ([54.187.51.154]:50644 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752667AbcDTNrP (ORCPT ); Wed, 20 Apr 2016 09:47:15 -0400 Subject: Re: [PATCH 1/3] i2c: s3c2410: Add missing clock unprepare on probe() error path To: Krzysztof Kozlowski , Kukjin Kim , Wolfram Sang , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org References: <1461144292-22141-1-git-send-email-k.kozlowski@samsung.com> Cc: Bartlomiej Zolnierkiewicz From: Javier Martinez Canillas Message-ID: <57178859.8040801@osg.samsung.com> Date: Wed, 20 Apr 2016 09:47:05 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1461144292-22141-1-git-send-email-k.kozlowski@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 999 Lines: 32 Hello Krzysztof, On 04/20/2016 05:24 AM, Krzysztof Kozlowski wrote: > If during probe() the s3c24xx_i2c_init() failed, the clock was left in > disabled but prepared state. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/i2c/busses/i2c-s3c2410.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c > index 362a6de54833..e9658af36f2e 100644 > --- a/drivers/i2c/busses/i2c-s3c2410.c > +++ b/drivers/i2c/busses/i2c-s3c2410.c > @@ -1200,6 +1200,7 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev) > clk_disable(i2c->clk); > if (ret != 0) { > dev_err(&pdev->dev, "I2C controller init failed\n"); > + clk_unprepare(i2c->clk); > return ret; > } > /* find the IRQ for this unit (note, this relies on the init call to > Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America