Subject: Re: [PATCH 3/4] x86/intel lbr: down with test_thread_flag(TIF_IA32)
To: Peter Zijlstra <peterz@infradead.org>,
        Andy Lutomirski <luto@amacapital.net>
References: <1460657414-12530-1-git-send-email-dsafonov@virtuozzo.com>
 <1460657414-12530-4-git-send-email-dsafonov@virtuozzo.com>
 <CALCETrUj2qnJ6HRLS3g19KEVf_uO4a96SkreJ4GAy0t1o6+prg@mail.gmail.com>
 <20160420112152.GA3408@twins.programming.kicks-ass.net>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, X86 ML <x86@kernel.org>,
        Robert Richter <rric@kernel.org>, <oprofile-list@lists.sf.net>,
        Dmitry Safonov <0x7f454c46@gmail.com>
From: Dmitry Safonov <dsafonov@virtuozzo.com>
Message-ID: <57178775.7020701@virtuozzo.com>
Date: Wed, 20 Apr 2016 16:43:17 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.1
MIME-Version: 1.0
In-Reply-To: <20160420112152.GA3408@twins.programming.kicks-ass.net>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2016 13:44:18.1577 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1298
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 965
Lines: 19

On 04/20/2016 02:21 PM, Peter Zijlstra wrote:
> On Thu, Apr 14, 2016 at 12:29:12PM -0700, Andy Lutomirski wrote:
>> On Thu, Apr 14, 2016 at 11:10 AM, Dmitry Safonov <dsafonov@virtuozzo.com> wrote:
>>> @@ -724,7 +727,7 @@ static int branch_type(unsigned long from, unsigned long to, int abort)
>>>           * on 64-bit systems running 32-bit apps
>>>           */
>>>   #ifdef CONFIG_X86_64
>>> -       is64 = kernel_ip((unsigned long)addr) || !test_thread_flag(TIF_IA32);
>>> +       is64 = kernel_ip((unsigned long)addr) || user_64bit_mode(regs);
>> Peterz, looking at this some more, would it make sense to pass
>> user_regs and interrupt_regs (or whatever we'd call it) all the way
>> through to here?
> Urgh; again, wtf wasn't I Cc'ed to these patches?

Sorry for that - that was my unintentional miss on git-send-email.

> And not sure; if we never need the user regs, calling
> perf_get_user_regs() to set all that up seems like a massive waste of
> cycles.