Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932719AbcDTOBY (ORCPT ); Wed, 20 Apr 2016 10:01:24 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:55136 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932104AbcDTOBW (ORCPT ); Wed, 20 Apr 2016 10:01:22 -0400 Date: Wed, 20 Apr 2016 16:01:17 +0200 From: Peter Zijlstra To: "Rafael J. Wysocki" Cc: Wanpeng Li , Ingo Molnar , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Wanpeng Li , Linux PM list , Steve Muckle Subject: Re: [PATCH] sched/cpufreq: don't trigger cpufreq update w/o real rt/deadline tasks running Message-ID: <20160420140117.GZ3448@twins.programming.kicks-ass.net> References: <1460958684-32105-1-git-send-email-wanpeng.li@hotmail.com> <6087716.bi8vDPiZNy@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6087716.bi8vDPiZNy@vostro.rjw.lan> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 743 Lines: 18 On Wed, Apr 20, 2016 at 02:32:35AM +0200, Rafael J. Wysocki wrote: > On Monday, April 18, 2016 01:51:24 PM Wanpeng Li wrote: > > Sometimes update_curr() is called w/o tasks actually running, it is > > captured by: > > u64 delta_exec = rq_clock_task(rq) - curr->se.exec_start; > > We should not trigger cpufreq update in this case for rt/deadline > > classes, and this patch fix it. > > > > Signed-off-by: Wanpeng Li > > The signed-off-by tag should agree with the From: header. One way to achieve > that is to add an extra From: line at the start of the changelog. > > That said, this looks like a good catch that should go into 4.6 to me. > > Peter, what do you think? I'm confused by the Changelog. *what* ?