Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932732AbcDTOCy (ORCPT ); Wed, 20 Apr 2016 10:02:54 -0400 Received: from lists.s-osg.org ([54.187.51.154]:50737 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751783AbcDTOCw (ORCPT ); Wed, 20 Apr 2016 10:02:52 -0400 Subject: Re: [PATCH 3/3] i2c: s3c2410: Cleanup indentation and comment style To: Krzysztof Kozlowski , Kukjin Kim , Wolfram Sang , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org References: <1461144292-22141-1-git-send-email-k.kozlowski@samsung.com> <1461144292-22141-3-git-send-email-k.kozlowski@samsung.com> Cc: Bartlomiej Zolnierkiewicz From: Javier Martinez Canillas Message-ID: <57178C04.6090109@osg.samsung.com> Date: Wed, 20 Apr 2016 10:02:44 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1461144292-22141-3-git-send-email-k.kozlowski@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 630 Lines: 21 Hello Krzysztof, On 04/20/2016 05:24 AM, Krzysztof Kozlowski wrote: > Improve the readability by: > - fixing indentation, > - switching to proper block comments, > - removing spurious blank lines, > - checkpatch: void function return statements are not generally useful > - checkpatch: braces {} are not necessary for any arm of this statement > - checkpatch: missing a blank line after declarations > > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America