Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754903AbcDTOea (ORCPT ); Wed, 20 Apr 2016 10:34:30 -0400 Received: from mail-oi0-f46.google.com ([209.85.218.46]:36019 "EHLO mail-oi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754661AbcDTOe1 (ORCPT ); Wed, 20 Apr 2016 10:34:27 -0400 MIME-Version: 1.0 In-Reply-To: <1461068317-28016-3-git-send-email-patrice.chotard@st.com> References: <1461068317-28016-1-git-send-email-patrice.chotard@st.com> <1461068317-28016-3-git-send-email-patrice.chotard@st.com> Date: Wed, 20 Apr 2016 16:34:26 +0200 Message-ID: Subject: Re: [PATCH 2/8] mfd: stmpe: Add reset support for all STMPE variant From: Linus Walleij To: Patrice CHOTARD Cc: Lee Jones , Alexandre Courbot , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Maxime Coquelin , amelie.delaunay@st.com, Shawn Guo , Sascha Hauer , Dinh Nguyen , Viresh Kumar , Shiraz Hashim , Stephen Warren , Thierry Reding Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 533 Lines: 18 On Tue, Apr 19, 2016 at 2:18 PM, wrote: > From: Patrice Chotard > > Reset was only implemented for STMPE1801 variant despite > all variant have a SOFT_RESET bit. > > For STMPE2401/2403/801/1601/1801 SOFT_RESET bit is bit 7 > of SYS_CTRL register. > For STMPE610/811 (which have the same variant id) SOFT_RESET > bit is bit 1 of SYS_CTRL register. > > Signed-off-by: Patrice Chotard Acked-by: Linus Walleij Yours, Linus Walleij