Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753793AbcDTPDY (ORCPT ); Wed, 20 Apr 2016 11:03:24 -0400 Received: from mx2.suse.de ([195.135.220.15]:46102 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751440AbcDTPDW (ORCPT ); Wed, 20 Apr 2016 11:03:22 -0400 Date: Wed, 20 Apr 2016 17:03:19 +0200 From: Johannes Thumshirn To: Andreas Werner Cc: morbidrsa@gmail.com, jthumshirn@suse.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mcb: Delete num_cells variable which is not required Message-ID: <20160420150319.GI28402@c203.arch.suse.de> References: <95acec18805bae2210c7ecb3405f6b5f085ea056.1461158147.git.andreas.werner@men.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <95acec18805bae2210c7ecb3405f6b5f085ea056.1461158147.git.andreas.werner@men.de> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1555 Lines: 46 On Wed, Apr 20, 2016 at 03:18:15PM +0200, Andreas Werner wrote: > The num_cells variable is only used in the dev_dbg print, > but we can directly use the ret variable which also includes the same > value. > > Signed-off-by: Andreas Werner > --- > drivers/mcb/mcb-pci.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/mcb/mcb-pci.c b/drivers/mcb/mcb-pci.c > index 99dd9db..b15a034 100644 > --- a/drivers/mcb/mcb-pci.c > +++ b/drivers/mcb/mcb-pci.c > @@ -35,7 +35,6 @@ static int mcb_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) > struct resource *res; > struct priv *priv; > int ret; > - int num_cells; > unsigned long flags; > > priv = devm_kzalloc(&pdev->dev, sizeof(struct priv), GFP_KERNEL); > @@ -92,9 +91,8 @@ static int mcb_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) > ret = chameleon_parse_cells(priv->bus, priv->mapbase, priv->base); > if (ret < 0) > goto out_mcb_bus; > - num_cells = ret; > > - dev_dbg(&pdev->dev, "Found %d cells\n", num_cells); > + dev_dbg(&pdev->dev, "Found %d cells\n", ret); > > mcb_bus_add_devices(priv->bus); > > -- > 2.6.2 > Applied to mcb-for-v4.7, Thanks -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850