Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751742AbcDTPV4 (ORCPT ); Wed, 20 Apr 2016 11:21:56 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:57070 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751450AbcDTPVy (ORCPT ); Wed, 20 Apr 2016 11:21:54 -0400 Date: Wed, 20 Apr 2016 16:21:43 +0100 From: Mark Brown To: Jon Hunter Cc: Thierry Reding , Liam Girdwood , linux-kernel@vger.kernel.org Message-ID: <20160420152143.GL3217@sirena.org.uk> References: <1460038959-21592-1-git-send-email-thierry.reding@gmail.com> <20160411140300.GH3351@sirena.org.uk> <20160411141101.GB27400@ulmo.ba.sec> <20160411141621.GI3351@sirena.org.uk> <5716059B.3080503@nvidia.com> <20160419154059.GW3217@sirena.org.uk> <57165857.5050809@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hlbXtwH6xCFjGtun" Content-Disposition: inline In-Reply-To: <57165857.5050809@nvidia.com> X-Cookie: Tomorrow, you can be anywhere. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/5] regulator: core: Resolve supply earlier X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1335 Lines: 38 --hlbXtwH6xCFjGtun Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 19, 2016 at 05:09:59PM +0100, Jon Hunter wrote: > On 19/04/16 16:40, Mark Brown wrote: > > This is *really* weird. Why would we need the list lock to do a > > device_register()? =20 > So I did not think that we would want someone to be able to=20 > look-up the regulator via of_find_regulator_by_node() until > it had been registered successfully. In fact I believe that > not locking around device_register() was causing some crashes > when I was testing. What that's saying to me is that the device_register() is too early and we shouldn't be registering the device until we're ready for it to be used. --hlbXtwH6xCFjGtun Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXF56DAAoJECTWi3JdVIfQOfEH/j1bm/Tga3szwzD44b5LaVew NwWHzdnXKus5GorEzPkVDlTqN9z4KAeG42FST3USr4rV1CcpOIUFfPIR2ltOHOf2 lWNMthXqkm6HbM71HVgRobScgAkNWlVaz8c/UoY/eshlcdqFIwyGyAVlP2zRFeaO hQfDW6KCluIxuGjdV8VJyB2nV4Zb+UqbGLyZCvypJn3gqLaHpGr0ZK9nh+jpfi8m K/XFCvwSaWokm9hn0ZKT3tm+qUW7Pg1rTM+SjTWiM9Lhto2gh0gkrXyiEYnPrJ02 OtxGbDaOxyB2V24skM8lS7EC7rlRm7iUIB7k9oIvG2cOP1gYIYm7UKdP37m8rCw= =ENpj -----END PGP SIGNATURE----- --hlbXtwH6xCFjGtun--