Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751807AbcDTQCO (ORCPT ); Wed, 20 Apr 2016 12:02:14 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:33753 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750717AbcDTQCM (ORCPT ); Wed, 20 Apr 2016 12:02:12 -0400 Subject: Re: [PATCH] sparc64: recognize and support Sonoma CPU type To: Allen Pais References: <1461085974-13534-1-git-send-email-khalid.aziz@oracle.com> <5717A63E.9000802@oracle.com> Cc: Rob Gardner , David Miller , David Aldridge , "linux-kernel@vger.kernel.org" , khalid@gonehiking.org, "sparclinux@vger.kernel.org" , Nitin Gupta From: Khalid Aziz Organization: Oracle Corp Message-ID: <5717A7FC.3000109@oracle.com> Date: Wed, 20 Apr 2016 10:02:04 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <5717A63E.9000802@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1593 Lines: 45 On 04/20/2016 09:54 AM, Allen Pais wrote: >> >> Signed-off-by: Khalid Aziz > >> --- >> arch/sparc/include/asm/spitfire.h | 1 + >> arch/sparc/kernel/cpu.c | 6 ++++++ >> arch/sparc/kernel/cpumap.c | 1 + >> arch/sparc/kernel/head_64.S | 8 ++++++++ >> arch/sparc/kernel/setup_64.c | 7 ++++++- >> arch/sparc/mm/init_64.c | 3 +++ >> 6 files changed, 25 insertions(+), 1 deletion(-) >> >> diff --git a/arch/sparc/include/asm/spitfire.h b/arch/sparc/include/asm/spitfire.h >> index 56f9338..1d8321c 100644 >> --- a/arch/sparc/include/asm/spitfire.h >> +++ b/arch/sparc/include/asm/spitfire.h >> @@ -48,6 +48,7 @@ >> #define SUN4V_CHIP_SPARC_M6 0x06 >> #define SUN4V_CHIP_SPARC_M7 0x07 >> #define SUN4V_CHIP_SPARC64X 0x8a >> +#define SUN4V_CHIP_SPARC_SN 0x8b >> #define SUN4V_CHIP_UNKNOWN 0xff > > Looks good to me. Do you think adding these also this patch makes sense or > it could be a separate patch. > > } > - if (!strcmp(sparc_pmu_type, "sparc-m7")) { > + if (!strcmp(sparc_pmu_type, "sparc-m7") || > + !strcmp(sparc_pmu_type, "sparc-sn")) { > sparc_pmu = &sparc_m7_pmu; > return true; > > Acked-by: Allen Pais > > - Allen > I would recommend that to be a separate patch. My goal with this patch is to address the core capabilities of sonoma and enable kernel to get optimized performance from the processor. Monitoring the performance can be a separate patch. -- Khalid