Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752194AbcDTTFy (ORCPT ); Wed, 20 Apr 2016 15:05:54 -0400 Received: from mail-gw2-out.broadcom.com ([216.31.210.63]:45548 "EHLO mail-gw2-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750804AbcDTTFw (ORCPT ); Wed, 20 Apr 2016 15:05:52 -0400 X-IronPort-AV: E=Sophos;i="5.24,510,1455004800"; d="scan'208";a="93698956" Subject: Re: [PATCH v2 1/1] arm64: dts: NS2 secondary core enablement via PSCI To: Luke Starrett , Florian Fainelli , Ray Jui , Scott Branden , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Catalin Marinas , Will Deacon References: <1461174002-18178-1-git-send-email-luke.starrett@broadcom.com> Cc: devicetree@vger.kernel.org, BCM Kernel Feedback , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Scott Branden Message-ID: <5717D2EA.4030900@broadcom.com> Date: Wed, 20 Apr 2016 12:05:14 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1461174002-18178-1-git-send-email-luke.starrett@broadcom.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2812 Lines: 103 Looks good while we are using PSCI-1.0 Acked-by: Scott Branden On 16-04-20 10:40 AM, Luke Starrett wrote: > Declare PSCI-1.0 node and enable CPU_ON method via PSCI. Spin-table > memreserve has been removed as well as syscon based reset, as PSCI-1.0 > expects reset implementation in firmware. > > Signed-off-by: Luke Starrett > --- > > Changes from v1: > - No code changes, adding missing reviewers to CC list > > arch/arm64/boot/dts/broadcom/ns2.dtsi | 31 +++++++++---------------------- > 1 file changed, 9 insertions(+), 22 deletions(-) > > diff --git a/arch/arm64/boot/dts/broadcom/ns2.dtsi b/arch/arm64/boot/dts/broadcom/ns2.dtsi > index 123cd9c..ec68ec1 100644 > --- a/arch/arm64/boot/dts/broadcom/ns2.dtsi > +++ b/arch/arm64/boot/dts/broadcom/ns2.dtsi > @@ -33,8 +33,6 @@ > #include > #include > > -/memreserve/ 0x84b00000 0x00000008; > - > / { > compatible = "brcm,ns2"; > interrupt-parent = <&gic>; > @@ -49,8 +47,7 @@ > device_type = "cpu"; > compatible = "arm,cortex-a57", "arm,armv8"; > reg = <0 0>; > - enable-method = "spin-table"; > - cpu-release-addr = <0 0x84b00000>; > + enable-method = "psci"; > next-level-cache = <&CLUSTER0_L2>; > }; > > @@ -58,8 +55,7 @@ > device_type = "cpu"; > compatible = "arm,cortex-a57", "arm,armv8"; > reg = <0 1>; > - enable-method = "spin-table"; > - cpu-release-addr = <0 0x84b00000>; > + enable-method = "psci"; > next-level-cache = <&CLUSTER0_L2>; > }; > > @@ -67,8 +63,7 @@ > device_type = "cpu"; > compatible = "arm,cortex-a57", "arm,armv8"; > reg = <0 2>; > - enable-method = "spin-table"; > - cpu-release-addr = <0 0x84b00000>; > + enable-method = "psci"; > next-level-cache = <&CLUSTER0_L2>; > }; > > @@ -76,8 +71,7 @@ > device_type = "cpu"; > compatible = "arm,cortex-a57", "arm,armv8"; > reg = <0 3>; > - enable-method = "spin-table"; > - cpu-release-addr = <0 0x84b00000>; > + enable-method = "psci"; > next-level-cache = <&CLUSTER0_L2>; > }; > > @@ -86,6 +80,11 @@ > }; > }; > > + psci { > + compatible = "arm,psci-1.0"; > + method = "smc"; > + }; > + > timer { > compatible = "arm,armv8-timer"; > interrupts = @@ -252,18 +251,6 @@ > mmu-masters; > }; > > - crmu: crmu@65024000 { > - compatible = "syscon"; > - reg = <0x65024000 0x100>; > - }; > - > - reboot@65024000 { > - compatible ="syscon-reboot"; > - regmap = <&crmu>; > - offset = <0x90>; > - mask = <0xfffffffd>; > - }; > - > gic: interrupt-controller@65210000 { > compatible = "arm,gic-400"; > #interrupt-cells = <3>; >